fluentui icon indicating copy to clipboard operation
fluentui copied to clipboard

Refactoring the utilities to reduce monosize of components

Open srmukher opened this issue 1 year ago • 2 comments

Refactoring the utilities to remove indirect function invocations. This reduced the monosize of each cartesian components by 4kB on an average. Additionally following changes were made:

  1. Removed other unused function arguments
  2. Removed event handlers like mouseLeave, blur, mouseOut which were empty functions.
  3. Made property shorthands as applicable, reduced if else blocks in simple logics
  4. Removed additional eslint comments per line when already same has been applied for whole file.
  5. Removed unused states within the component classes.
  6. Used destructuring of argument values of getGraphData function which removed d3-axis import and axis type declarations from each chart. image

srmukher avatar May 07 '24 06:05 srmukher

📊 Bundle size report

✅ No changes found

fabricteam avatar May 07 '24 06:05 fabricteam

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

codesandbox-ci[bot] avatar May 07 '24 06:05 codesandbox-ci[bot]

Can you update the PR description to represent only the changes in this PR.

AtishayMsft avatar May 13 '24 06:05 AtishayMsft

Performed Full test pass on this PR https://fluentuipr.z22.web.core.windows.net/pull/31291/public-docsite/index.html#/controls. Tested the functionality (manual testing) for all the charts.

Thanneerudeepika avatar May 21 '24 06:05 Thanneerudeepika