fluentui icon indicating copy to clipboard operation
fluentui copied to clipboard

Virtualizer: ScrollTo hooks & callbacks

Open Mitch-At-Work opened this issue 2 years ago • 4 comments

New Behavior

ScrollTo hooks for scrolling animated or instantly to a specific item index Callback for when a flagged index has been rendered Optional isScrolling flag available in the child render function for users to render lightweight placeholders

Related Issue(s)

https://github.com/microsoft/fluentui/issues/27217 https://github.com/microsoft/fluentui/issues/27218 https://github.com/microsoft/fluentui/issues/27219

Mitch-At-Work avatar May 16 '23 16:05 Mitch-At-Work

Perf Analysis (@fluentui/react-components)

Scenario Render type Master Ticks PR Ticks Iterations Status
FluentProviderWithTheme mount 78 85 10 Possible regression
InfoButton mount 17 16 5000 Possible regression
All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 578 580 5000
Button mount 284 298 5000
Field mount 1009 1052 5000
FluentProvider mount 663 666 5000
FluentProviderWithTheme mount 78 85 10 Possible regression
FluentProviderWithTheme virtual-rerender 84 70 10
FluentProviderWithTheme virtual-rerender-with-unmount 87 83 10
InfoButton mount 17 16 5000 Possible regression
MakeStyles mount 860 843 50000
Persona mount 1598 1542 5000
SpinButton mount 1256 1288 5000

fabricteam avatar May 16 '23 17:05 fabricteam

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 4e32934017be878e9b4721deb2b4d31e7b04c39d:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

codesandbox-ci[bot] avatar May 16 '23 17:05 codesandbox-ci[bot]

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-components
react-components: Button, FluentProvider & webLightTheme
64.935 kB
17.918 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
211.151 kB
58.715 kB
react-components
react-components: FluentProvider & webLightTheme
36.168 kB
11.964 kB
react-portal-compat
PortalCompatProvider
6.473 kB
2.196 kB
🤖 This report was generated against 1acc2cdf9ab63707eb26d656fca5161680df42c5

fabricteam avatar May 16 '23 17:05 fabricteam

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 1acc2cdf9ab63707eb26d656fca5161680df42c5 (build)

size-auditor[bot] avatar May 16 '23 17:05 size-auditor[bot]

🕵 fluentuiv9 No visual regressions between this PR and main

fabricteam avatar Jun 07 '23 17:06 fabricteam

:tada:@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot avatar Jun 08 '23 07:06 msft-fluent-ui-bot

:tada:@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot avatar Jun 08 '23 07:06 msft-fluent-ui-bot

:tada:@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot avatar Jun 08 '23 07:06 msft-fluent-ui-bot

:tada:@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot avatar Jun 08 '23 07:06 msft-fluent-ui-bot

:tada:@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot avatar Jun 08 '23 07:06 msft-fluent-ui-bot

:tada:@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot avatar Jun 08 '23 07:06 msft-fluent-ui-bot

:tada:@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot avatar Jun 08 '23 07:06 msft-fluent-ui-bot

:tada:@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot avatar Jun 08 '23 07:06 msft-fluent-ui-bot

:tada:@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot avatar Jun 08 '23 07:06 msft-fluent-ui-bot

:tada:@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot avatar Jun 08 '23 07:06 msft-fluent-ui-bot

:tada:@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot avatar Jun 21 '23 07:06 msft-fluent-ui-bot

:tada:@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot avatar Jun 21 '23 07:06 msft-fluent-ui-bot