fluentui-apple icon indicating copy to clipboard operation
fluentui-apple copied to clipboard
verified publisher icon microsoft

[Fluent 2 iOS] Fix HUD color contrast issues

Open laminesm opened this issue 3 years ago • 0 comments

Platforms Impacted

  • [x] iOS
  • [ ] macOS

Description of changes

The hud now uses new tokens that fix the existing color contrast issues. The hud's activity indicator needs different opacities for its color token in light and dark schemes. Therefore, now HUDTokens returns a UIColor with pre-applied opacity for the indicator, instead of a DynamicColor.

Verification

Changes were tested on the demo app.

Before After
before_activity_light after_activity_light
before_activity_dark after_activity_dark
before_failure_light after_failure_light
before_failure_dark after_failure_dark
before_nolabel_light after_nolabel_light
before_nolabel_dark after_nolabel_dark
before_swiftui_light after_swiftui_nolabel_light
before_swiftui_dark after_swiftui_nolabel_dark
before_swiftui_label_light after_swiftui_light
before_swiftui_label_dark after_swiftui_dark

Pull request checklist

This PR has considered:

  • [x] Light and Dark appearances
  • [ ] iOS supported versions (all major versions greater than or equal current target deployment version)
  • [ ] VoiceOver and Keyboard Accessibility
  • [ ] Internationalization and Right to Left layouts
  • [ ] Different resolutions (1x, 2x, 3x)
  • [ ] Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)
  • [ ] iPad Pointer interaction
  • [x] SwiftUI consumption (validation or new demo scenarios needed)
  • [ ] Objective-C exposure (provide it only if needed)
Microsoft Reviewers: Open in CodeFlow

laminesm avatar Sep 27 '22 16:09 laminesm