fluentui-apple icon indicating copy to clipboard operation
fluentui-apple copied to clipboard

[Draft] [FHL] Create a Readme section for demo app controls

Open laminesm opened this issue 3 years ago • 1 comments

Platforms Impacted

  • [x] iOS
  • [ ] macOS

Description of changes

I've created a ReadmeViewController that sets up the readme scroll view, constraints and label. It is then added to the DemoController class alongside a setupReadmeText function to be called in the subclass.
I created a RedmeStrings class to store all the readme strings.

So far I have only added a few strings for this draft. Once the approach is validated, the same process could be applied to DemoTableViewController.

Verification

Light Dark
badge_light badge_dark
button_light button_dark
date_time_light date_time_dark
segmented_light segmented_dark
light_gif dark_gif

Pull request checklist

This PR has considered:

  • [x] Light and Dark appearances
  • [ ] iOS supported versions (all major versions greater than or equal current target deployment version)
  • [ ] VoiceOver and Keyboard Accessibility
  • [ ] Internationalization and Right to Left layouts
  • [ ] Different resolutions (1x, 2x, 3x)
  • [ ] Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)
  • [ ] iPad Pointer interaction
  • [ ] SwiftUI consumption (validation or new demo scenarios needed)
  • [ ] Objective-C exposure (provide it only if needed)
Microsoft Reviewers: Open in CodeFlow

laminesm avatar Sep 23 '22 18:09 laminesm

Could you add a screenshot for TableViewCell? That demo controller also has a "Select" button in addition to the settings, so it'd be interesting to see what the top bar would look like

sophialee0416 avatar Sep 28 '22 22:09 sophialee0416

a thought - instead of "read me" which is bit of long text doesn't look as pretty in larger text mode can we use "i" in a circle icon ?

harrieshin avatar Oct 17 '22 18:10 harrieshin