fluentui-apple icon indicating copy to clipboard operation
fluentui-apple copied to clipboard
verified publisher icon microsoft

Adjust Notification Padding Tokens

Open jeaniehuynh opened this issue 3 years ago • 4 comments

Platforms Impacted

  • [x] iOS
  • [ ] macOS

Description of changes

The bounds of a couple elements were off in the figma, so the tokens were slightly wrong. This change adjusts them to what they should be!

Before After
Simulator Screen Shot - iPad Pro (12 9-inch) (5th generation) - 2022-08-12 at 10 55 20 Simulator Screen Shot - iPad Pro (12 9-inch) (5th generation) - 2022-08-12 at 13 31 13
Simulator Screen Shot - iPad Pro (12 9-inch) (5th generation) - 2022-08-12 at 10 55 24 Simulator Screen Shot - iPad Pro (12 9-inch) (5th generation) - 2022-08-12 at 13 31 20

Pull request checklist

This PR has considered:

  • [ ] Light and Dark appearances
  • [ ] iOS supported versions (all major versions greater than or equal current target deployment version)
  • [ ] VoiceOver and Keyboard Accessibility
  • [ ] Internationalization and Right to Left layouts
  • [ ] Different resolutions (1x, 2x, 3x)
  • [ ] Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)
  • [ ] iPad Pointer interaction
  • [ ] SwiftUI consumption (validation or new demo scenarios needed)
  • [ ] Objective-C exposure (provide it only if needed)
Microsoft Reviewers: Open in CodeFlow

jeaniehuynh avatar Aug 12 '22 17:08 jeaniehuynh

minimumHeightForOneLine still correctly increase larger text and longer message that will be more that one line? would you midn updating your before / afterscreenshots please?

harrieshin avatar Aug 12 '22 19:08 harrieshin

minimumHeightForOneLine still correctly increase larger text and longer message that will be more that one line? would you midn updating your before / afterscreenshots please?

@harrieshin Screenshots updated! Let me actually confirm the minimum height specs with design team. The figma doesn't specify heights for one-line scenario.

jeaniehuynh avatar Aug 12 '22 19:08 jeaniehuynh

minimumHeightForOneLine still correctly increase larger text and longer message that will be more that one line? would you midn updating your before / afterscreenshots please?

@harrieshin Screenshots updated! Let me actually confirm the minimum height specs with design team. The figma doesn't specify heights for one-line scenario.

Ian just updated the figma so it should be 62 for multiline and 52 for single line.

joannaquu avatar Aug 12 '22 21:08 joannaquu

minimumHeightForOneLine still correctly increase larger text and longer message that will be more that one line? would you midn updating your before / afterscreenshots please?

@harrieshin Screenshots updated! Let me actually confirm the minimum height specs with design team. The figma doesn't specify heights for one-line scenario.

Ian just updated the figma so it should be 62 for multiline and 52 for single line.

62 was just the height for that specific example in the figma, but the minimum should be 52 for all toasts! image

jeaniehuynh avatar Aug 12 '22 23:08 jeaniehuynh