fluentui-apple icon indicating copy to clipboard operation
fluentui-apple copied to clipboard

[Fluent 2 iOS] TableViewCell colors update (2/2)

Open laminesm opened this issue 3 years ago • 0 comments

Platforms Impacted

  • [x] iOS
  • [ ] macOS

Description of changes

As we are trying to move away from Colors.swift, the Colors extension was removed from TableViewCell. Some of the colors in the Table struct were used by other controls in fluent. In fact, PersonaListView, TableViewHeaderFooterTitleView & PopupMenuItemCell had dependencies to some of these colors and they were all updated to use their appropriate color tokens instead. The Objective-C colors were changed into functions that take in a FluentTheme and output the right token.

Verification

Before After
before_persona_light after_persona_light
before_persona_dark after_persona_dark
before_title_light after_title_light
before_title_dark after_title_dark
before after

Pull request checklist

This PR has considered:

  • [x] Light and Dark appearances
  • [ ] iOS supported versions (all major versions greater than or equal current target deployment version)
  • [ ] VoiceOver and Keyboard Accessibility
  • [ ] Internationalization and Right to Left layouts
  • [ ] Different resolutions (1x, 2x, 3x)
  • [ ] Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)
  • [ ] iPad Pointer interaction
  • [ ] SwiftUI consumption (validation or new demo scenarios needed)
  • [ ] Objective-C exposure (provide it only if needed)
Microsoft Reviewers: Open in CodeFlow

laminesm avatar Aug 09 '22 22:08 laminesm