fluentui-apple icon indicating copy to clipboard operation
fluentui-apple copied to clipboard

[Fluent 2 iOS] TableViewCell colors update (1/2)

Open laminesm opened this issue 3 years ago • 2 comments

Platforms Impacted

  • [x] iOS
  • [ ] macOS

Description of changes

TableViewCell colors were updated to match fluent 2 specs.

NOTE: These changes do not include:

  • Color changes to ActionsCell -> This will be updated in a separate PR when the work on shared colors alias tokens is done.
  • Removal of Colors extension -> A new PR will be up shortly dealing with this and addressing the dependencies.

Verification

Before After
before_1_light after_1_light
before_1_dark after_1_dark
before_2_light after_2_light
before_2_dark after_2_dark
before_3_light after_3_light
before_3_dark after_3_dark
before_4_light after_4_light
before_4_dark after_4_dark
before_grouped_light after_grouped_light
before_grouped_dark after_grouped_dark
before_selected_light after_selected_light
before_selected_dark after_selected_dark
before_selected_grouped_light after_selected_grouped_light
before_selected_grouped_dark after_selected_grouped_dark
before_dark_elevated after_dark_elevated
before_dark_elevated_grouped after_dark_elevated_grouped
before_light after_light
before_grouped_light after_grouped_light
before_dark after_dark
before_grouped_dark after_grouped_dark

Pull request checklist

This PR has considered:

  • [x] Light and Dark appearances
  • [ ] iOS supported versions (all major versions greater than or equal current target deployment version)
  • [ ] VoiceOver and Keyboard Accessibility
  • [ ] Internationalization and Right to Left layouts
  • [ ] Different resolutions (1x, 2x, 3x)
  • [ ] Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)
  • [ ] iPad Pointer interaction
  • [ ] SwiftUI consumption (validation or new demo scenarios needed)
  • [ ] Objective-C exposure (provide it only if needed)
Microsoft Reviewers: Open in CodeFlow

laminesm avatar Aug 09 '22 18:08 laminesm

what does keyboard selection looks like on ipad?

harrieshin avatar Aug 10 '22 17:08 harrieshin

what does keyboard selection looks like on ipad?

The description is updated with screenshots of iPad keyboard selection.

laminesm avatar Aug 12 '22 19:08 laminesm