fluentui-apple icon indicating copy to clipboard operation
fluentui-apple copied to clipboard

Integrating Fluent2 HUD into main.

Open rdeassis opened this issue 3 years ago • 2 comments

Platforms Impacted

  • [x] iOS
  • [ ] macOS

Description of changes

This change integrates the new Fluent2 Heads Up Display into the main branch. The new version is implemented in SwiftUI and therefore is compatible for use in SwiftUI only environments. Modifiers that de SwiftUI HUD depends on are also being added (AnimationCompletionModifier and PresentationModifier)

For context, the PRs that merged this code into the fluent2-tokens (formerly vnext-tokens) branch are referenced below:

  • #951
  • #952
  • #960

Verification

  • Tests exercising Demo App scenarios.
  • Validation on consuming codebase currently underway (devmain).
Light Mode Dark Mode
HUD_UIKit_light HUD_UIKit_dark
HUD_SwiftUI_light HUD_SwiftUI_dark

Pull request checklist

This PR has considered:

  • [x] Light and Dark appearances
  • [x] iOS supported versions (all major versions greater than or equal current target deployment version)
  • [ ] VoiceOver and Keyboard Accessibility
  • [ ] Internationalization and Right to Left layouts
  • [ ] Different resolutions (1x, 2x, 3x)
  • [x] Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)
  • [ ] iPad Pointer interaction
  • [x] SwiftUI consumption (validation or new demo scenarios needed)
  • [ ] Objective-C exposure (provide it only if needed)
Microsoft Reviewers: Open in CodeFlow

rdeassis avatar Jun 24 '22 16:06 rdeassis

Blocking merge until we can figure out versioning.

This is not an API breaking change, so it shouldn't be tied to issues in versioning.

rdeassis avatar Jun 24 '22 22:06 rdeassis

Blocking merge until we can figure out versioning.

This is not an API breaking change, so it shouldn't be tied to issues in versioning.

We will be release the HUD in the same release as other controls that will break the public API. This will be released in the next minor version update (0.6.0) currently.

rdeassis avatar Jun 30 '22 16:06 rdeassis