finnts icon indicating copy to clipboard operation
finnts copied to clipboard

feat: auto detect date_type when not provided

Open laresbernardo opened this issue 1 year ago • 6 comments

The user may or may not specify date_range. It's not needed given it can be calculated. By default I propose setting date_type = NULL so it happens automatically instead of the current obligatory input. This update doesn't break past versions usage.

laresbernardo avatar Feb 26 '24 11:02 laresbernardo

@microsoft-github-policy-service agree

laresbernardo avatar Feb 26 '24 11:02 laresbernardo

Hey @laresbernardo thanks for the new feature! Can you please add a test in its own file in the test folder so we know it works for various types of data. Maybe using example data from the modeltime package.

mitokic avatar Mar 14 '24 17:03 mitokic

Thanks for the feedback @mitokic Added new test.

laresbernardo avatar Mar 16 '24 09:03 laresbernardo

Looking good to land? @mitokic

laresbernardo avatar Apr 04 '24 15:04 laresbernardo

@laresbernardo please review my comments and resolve them. Thanks!

mitokic avatar Apr 11 '24 17:04 mitokic

Hi @mitokic I don't see any unresolved conversations. The tests are already implemented in commit 58d9e29. Am I missing something else? Have a nice weekend.

laresbernardo avatar Apr 12 '24 18:04 laresbernardo