fast icon indicating copy to clipboard operation
fast copied to clipboard

Turned on noImplicitAny and strictPropertyInitialization for fast-router

Open NiteshSethi09 opened this issue 3 years ago • 2 comments

Pull Request

📖 Description

Made changes in tsconfig.json and removed all the eslint errors. Added relevant types and passed all the test cases. Updated api-report.md file.

🎫 Issues

Some types still needs to be updated from any type to it's relevant type.

👩‍💻 Reviewer Notes

I added index type for key value pairs and set default value for some class fields. Need to replace few types with any type due to incompatible types, will be fixed in near future.

📑 Test Plan

All test have been passed from my end.

✅ Checklist

General

  • [ ] I have included a change request file using $ yarn change
  • [ ] I have added tests for my changes.
  • [x] I have tested my changes.
  • [ ] I have updated the project documentation to reflect my changes.
  • [x] I have read the CONTRIBUTING documentation and followed the standards for this project.

Component-specific

⏭ Next Steps

NiteshSethi09 avatar Aug 25 '22 18:08 NiteshSethi09

CLA assistant check
All CLA requirements met.

ghost avatar Sep 10 '22 13:09 ghost

@NiteshSethi09 I'm sorry it took me so long to review this. It looks pretty good. I had one basic change that I thought could be made in a few places. I'd also like @nicholasrice to do a quick review of the utilities code since he's more familiar with that. With Nick's approval and the couple of minor changes I noted, we can get this merged pretty quickly.

Thanks for working on this!

EisenbergEffect avatar Sep 16 '22 00:09 EisenbergEffect

@nicholasrice I'm looking for a resolution on this. May we work together to get it resolved soon?

NiteshSethi09 avatar Jan 25 '23 19:01 NiteshSethi09