fast icon indicating copy to clipboard operation
fast copied to clipboard

fix: tests silently fail to execute in fast-foundation

Open sknoslo opened this issue 3 years ago • 2 comments

🐛 Bug Report

When executing tests in fast-foundation several hundred tests silently fail to execute.

💻 Repro or Code Sample

On master branch in the fast-foundation project run yarn run build && yarn run test

🤔 Expected Behavior

All tests should execute and succeed

😯 Current Behavior

Only some (872 as of this writing) of the tests execute.

💁 Possible Solution

Seems to be something related to the Radio components. If you skip the Radio and Radio Group suites, the rest of the tests execute (with some failures). Was not obvious to me exactly what was causing it, but seems related to setting certain properties on the Radio component.

🌍 Your Environment

  • OS & Device: Windows and Linux
  • Browser: Google Chrome and Mozilla FireFox

sknoslo avatar Jun 13 '22 17:06 sknoslo

@chrisdholt Know anything about this?

EisenbergEffect avatar Jun 13 '22 18:06 EisenbergEffect

@chrisdholt Know anything about this?

I’ll work on a repro. FYI that in at least one I just found a missing reference to DOM (see my PR) which could be related? I’ll loop back once I investigate.

chrisdholt avatar Jun 13 '22 18:06 chrisdholt

It's been awhile, but revisiting this in an attempt to repro and I still haven't been able to do so. I do get a couple of errors w/r/t Data Grid and a notice of a flaky test, but I get over 2600 executing. Closing this for now, but feel free to reopen if you stiil repro.

image

chrisdholt avatar Jan 16 '23 06:01 chrisdholt

@chrisdholt thanks. Yeah I think this has been resolved since the tests were updated to Playwright if I understand that move correctly.

sknoslo avatar Jan 16 '23 21:01 sknoslo