data-formulator icon indicating copy to clipboard operation
data-formulator copied to clipboard
verified publisher icon microsoft

Feature/docker support

Open dbsectrainer opened this issue 11 months ago • 9 comments

  • Add Dockerfile for containerization
  • Add docker-compose.yml for easy deployment
  • Add docker-entrypoint.sh for container initialization
  • Add configuration templates and documentation
  • Support API key configuration through environment variables
  • Add comprehensive Docker setup instructions

Fixes #85

dbsectrainer avatar Feb 14 '25 02:02 dbsectrainer

@microsoft-github-policy-service agree

dbsectrainer avatar Feb 14 '25 02:02 dbsectrainer

Thanks! Does it also work on Windows? I see a .sh file

danmarshall avatar Feb 14 '25 04:02 danmarshall

I tried running, I got this error:

 => [data-formulator-dev development  4/12] WORKDIR /app                                                                                                                                  0.2s
 => [data-formulator-dev development  5/12] RUN mkdir -p /app/config                                                                                                                      0.5s
 => ERROR [data-formulator-dev development  6/12] COPY docker-entrypoint.sh /app/                                                                                                         0.0s

danmarshall avatar Feb 19 '25 21:02 danmarshall 

 => [data-formulator-dev development  4/12] WORKDIR /app                                                                                                                                  0.2s
 => [data-formulator-dev development  5/12] RUN mkdir -p /app/config                                                                                                                      0.5s
 => ERROR [data-formulator-dev development  6/12] COPY docker-entrypoint.sh /app/

Addressed issue in recent change. successfully builds now.

dbsectrainer avatar Mar 03 '25 02:03 dbsectrainer

I run into multiple issues trying to work with this docker setup:

  1. I run into the problem of Error response from daemon: failed to create task for container: failed to create shim task: OCI runtime create failed: runc create failed: unable to start container process: exec: "/app/docker-entrypoint.sh": stat /app/docker-entrypoint.sh: no such file or directory: unknown doing docker compose. I need to fix by updating entrypoint setup in docker-compose.yml with entrypoint: ["/bin/bash", "/app/docker/docker-entrypoint.sh"]

  2. Still have trouble opening the page on docker, I tried adding --host to do network mapping but it somehow doesn't work yet.

Chenglong-MS avatar Mar 03 '25 18:03 Chenglong-MS

Thanks for the quick fix! I still run into some issue:

  1. entrypoint: [ "/bin/bash", "/app/docker/docker-entrypoint.sh" ] --> entrypoint: [ "/bin/bash", "/app/docker-entrypoint.sh" ] since it is copied as /app/docker-entrypoint.sh

  2. still have issue routing 127.0.0.1 to my browser

Chenglong-MS avatar Mar 03 '25 18:03 Chenglong-MS

Thanks for the quick fix! I still run into some issue:

  1. entrypoint: [ "/bin/bash", "/app/docker/docker-entrypoint.sh" ] --> entrypoint: [ "/bin/bash", "/app/docker-entrypoint.sh" ] since it is copied as /app/docker-entrypoint.sh
  2. still have issue routing 127.0.0.1 to my browser

You should now be able to run command "docker compose -f docker/docker-compose.yml down && docker compose -f docker/docker-compose.yml up --build data-formulator-dev" and see tool on port :5173

dbsectrainer avatar Mar 03 '25 19:03 dbsectrainer

Can you do this PR to dev branch? I’ll still need to tweak some minor stuff there, especially for the data-formulator-dev

From: Donnivis Baker @.> Sent: Monday, March 3, 2025 11:26:07 AM To: microsoft/data-formulator @.> Cc: Chenglong Wang @.>; Comment @.> Subject: Re: [microsoft/data-formulator] Feature/docker support (PR #90)

Thanks for the quick fix! I still run into some issue:

  1. entrypoint: [ "/bin/bash", "/app/docker/docker-entrypoint.sh" ] --> entrypoint: [ "/bin/bash", "/app/docker-entrypoint.sh" ] since it is copied as /app/docker-entrypoint.sh
  2. still have issue routing 127.0.0.1 to my browser

You should now be able to run command "docker compose -f docker/docker-compose.yml down && docker compose -f docker/docker-compose.yml up --build data-formulator-dev" and see tool on port :5173

— Reply to this email directly, view it on GitHubhttps://github.com/microsoft/data-formulator/pull/90#issuecomment-2695342146, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AWJXEPEQUGQ4VY47DHKEWI32SSUE7AVCNFSM6AAAAABXDTTYCGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMOJVGM2DEMJUGY. You are receiving this because you commented.Message ID: @.***>

[dbsectrainer]dbsectrainer left a comment (microsoft/data-formulator#90)https://github.com/microsoft/data-formulator/pull/90#issuecomment-2695342146

Thanks for the quick fix! I still run into some issue:

  1. entrypoint: [ "/bin/bash", "/app/docker/docker-entrypoint.sh" ] --> entrypoint: [ "/bin/bash", "/app/docker-entrypoint.sh" ] since it is copied as /app/docker-entrypoint.sh
  2. still have issue routing 127.0.0.1 to my browser

You should now be able to run command "docker compose -f docker/docker-compose.yml down && docker compose -f docker/docker-compose.yml up --build data-formulator-dev" and see tool on port :5173

— Reply to this email directly, view it on GitHubhttps://github.com/microsoft/data-formulator/pull/90#issuecomment-2695342146, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AWJXEPEQUGQ4VY47DHKEWI32SSUE7AVCNFSM6AAAAABXDTTYCGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMOJVGM2DEMJUGY. You are receiving this because you commented.Message ID: @.***>

Chenglong-MS avatar Mar 03 '25 20:03 Chenglong-MS

Updated PR branch to dev as requested

Can you do this PR to dev branch? I’ll still need to tweak some minor stuff there, especially for the data-formulator-dev … ________________________________ From: Donnivis Baker @.> Sent: Monday, March 3, 2025 11:26:07 AM To: microsoft/data-formulator @.> Cc: Chenglong Wang @.>; Comment @.> Subject: Re: [microsoft/data-formulator] Feature/docker support (PR #90) Thanks for the quick fix! I still run into some issue: 1. entrypoint: [ "/bin/bash", "/app/docker/docker-entrypoint.sh" ] --> entrypoint: [ "/bin/bash", "/app/docker-entrypoint.sh" ] since it is copied as /app/docker-entrypoint.sh 2. still have issue routing 127.0.0.1 to my browser You should now be able to run command "docker compose -f docker/docker-compose.yml down && docker compose -f docker/docker-compose.yml up --build data-formulator-dev" and see tool on port :5173 — Reply to this email directly, view it on GitHub<#90 (comment)>, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AWJXEPEQUGQ4VY47DHKEWI32SSUE7AVCNFSM6AAAAABXDTTYCGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMOJVGM2DEMJUGY. You are receiving this because you commented.Message ID: @.> [dbsectrainer]dbsectrainer left a comment (microsoft/data-formulator#90)<#90 (comment)> Thanks for the quick fix! I still run into some issue: 1. entrypoint: [ "/bin/bash", "/app/docker/docker-entrypoint.sh" ] --> entrypoint: [ "/bin/bash", "/app/docker-entrypoint.sh" ] since it is copied as /app/docker-entrypoint.sh 2. still have issue routing 127.0.0.1 to my browser You should now be able to run command "docker compose -f docker/docker-compose.yml down && docker compose -f docker/docker-compose.yml up --build data-formulator-dev" and see tool on port :5173 — Reply to this email directly, view it on GitHub<#90 (comment)>, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AWJXEPEQUGQ4VY47DHKEWI32SSUE7AVCNFSM6AAAAABXDTTYCGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMOJVGM2DEMJUGY. You are receiving this because you commented.Message ID: @.>

Updated PR branch as requested

dbsectrainer avatar Mar 04 '25 00:03 dbsectrainer