cpprestsdk icon indicating copy to clipboard operation
cpprestsdk copied to clipboard

support boost 1.87

Open miyanyan opened this issue 1 year ago • 5 comments

hi, asio removed some previously deprecated facilities, see https://www.boost.org/doc/libs/1_87_0/doc/html/boost_asio/history.html

I found this when I update vcpkg's boost to 1.87

I can create a pr but I don't know what is the minimum boost version you support

if only support boost>=1.66.0(vcpkg's boost version start from 1.66.0), the changes will be easier

miyanyan avatar Jan 18 '25 09:01 miyanyan

I wish you better luck than the other stale issues on this topic which have been stale for 4 years,

https://github.com/microsoft/cpprestsdk/issues/1323

Lord-Kamina avatar Jan 21 '25 10:01 Lord-Kamina

There is this in progress meanwhile: https://github.com/dcriv/cpprestsdk/tree/support_boost_1.87_%231815

dcriv avatar Apr 01 '25 08:04 dcriv

There is this in progress meanwhile: https://github.com/dcriv/cpprestsdk/tree/support_boost_1.87_%231815

It seems should support boost >= 1.58 in this comment https://github.com/microsoft/cpprestsdk/pull/1339#discussion_r383026727

so some functions like asio::post should not be used directly, and this requires a lot of work

miyanyan avatar Apr 01 '25 08:04 miyanyan

The boost >= 1.58 in https://github.com/microsoft/cpprestsdk/pull/1339#discussion_r383026727 was because of Ubuntu 16.04, which is officially EOL since April 30th 2021. Ubuntu 18.04 is EOL since 31 May 2023.

So I don't think there's a need to support such old versions

here's a table I put together that lists the EOL + Boost version in launchpad

Ubuntu Codename EOL Boost
16.04 Xenial 2021-04-30 1.58.0
18.04 Bionic 2023-05-31 1.65.1
20.04 Focal June 2025 1.71.0
22.04 Jammy April 2027 1.74.0
24.04 Noble April 2029 1.83.0

If I'm understanding correctly, boost 1.66.0+ has these free functions: https://github.com/boostorg/asio/commit/b60e92b13ef68dfbb9af180d76eae41d22e19356

jmarrec avatar Apr 03 '25 08:04 jmarrec

The boost >= 1.58 in #1339 (comment) was because of Ubuntu 16.04, which is officially EOL since April 30th 2021. Ubuntu 18.04 is EOL since 31 May 2023.

So I don't think there's a need to support such old versions

If I'm understanding correctly, boost 1.66.0+ has these free functions: [boostorg/asio@b60e92b](https://github.com/boostorg/asio/commit/b60e92b13ef68dfbb9af180d76eae41d22e193

Only 1.66+ versions supported is better, but the maintainers may not approve such pr ...

miyanyan avatar Apr 06 '25 03:04 miyanyan