component-detection icon indicating copy to clipboard operation
component-detection copied to clipboard

Add python version conditional dependency check

Open FernandoRojo opened this issue 2 years ago • 2 comments

add in python_version dependency check when processing METADATA files

FernandoRojo avatar Jan 17 '24 01:01 FernandoRojo

Codecov Report

Attention: Patch coverage is 69.13580% with 25 lines in your changes missing coverage. Please review.

Project coverage is 76.2%. Comparing base (e626211) to head (5d38292).

Files Patch % Lines
...ectors/pip/Contracts/PipDependencySpecification.cs 80.0% 7 Missing and 4 partials :warning:
...entDetection.Detectors/pip/PythonCommandService.cs 0.0% 7 Missing :warning:
...ComponentDetection.Detectors/pip/PythonResolver.cs 25.0% 6 Missing :warning:
...entDetection.Detectors/pip/PipComponentDetector.cs 90.9% 0 Missing and 1 partial :warning:
Additional details and impacted files
@@          Coverage Diff          @@
##            main    #973   +/-   ##
=====================================
  Coverage   76.2%   76.2%           
=====================================
  Files        257     257           
  Lines      11401   11481   +80     
  Branches    1142    1154   +12     
=====================================
+ Hits        8697    8759   +62     
- Misses      2371    2384   +13     
- Partials     333     338    +5     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jan 17 '24 01:01 codecov[bot]

👋 Hi! It looks like you modified some files in the Detectors folder. You may need to bump the detector versions if any of the following scenarios apply:

  • The detector detects more or fewer components than before
  • The detector generates different parent/child graph relationships than before
  • The detector generates different devDependencies values than before

If none of the above scenarios apply, feel free to ignore this comment 🙂

github-actions[bot] avatar Feb 01 '24 20:02 github-actions[bot]