component-detection icon indicating copy to clipboard operation
component-detection copied to clipboard
verified publisher icon microsoft

Strong-name the assemblies

Open dfederm opened this issue 3 years ago • 6 comments

This strong-names the assemblies so that applications which are themselves strong-named can use these libraries.

The snk file was generated by running: sn -k StrongName.snk

dfederm avatar Feb 28 '22 21:02 dfederm

@dfederm Are we okay to still merge this, even if we're blocked with upstream dependencies?

EDIT: Nope! Moving this to draft for now.

JamieMagee avatar Mar 29 '22 20:03 JamieMagee

I opened a PR upstream https://github.com/dotnet/Docker.DotNet/pull/567

JamieMagee avatar Jun 29 '22 23:06 JamieMagee

PR merged upstream. Waiting for a release now.

JamieMagee avatar Jan 04 '23 19:01 JamieMagee

Version 3.125.13 was released upstream with the required strong-naming 🎉

JamieMagee avatar Mar 01 '23 20:03 JamieMagee

See #453

JamieMagee avatar Mar 01 '23 20:03 JamieMagee

@dfederm can you rebase this branch please? I don't have permissions to push to your fork, but I've created a branch you can reset to: strong-naming.

We're getting closer, but the build still fails due to a lack of strong named assemblies for Tomlyn and Valleysoft.DockerfileModel. I've created issues upstream:

  • https://github.com/xoofx/Tomlyn/issues/56
  • https://github.com/mthalman/DockerfileModel/issues/101

I'll also create pull requests when I have time.

JamieMagee avatar Mar 01 '23 21:03 JamieMagee