microsoft
Do you need onStartupFinished?
Describe the bug
When you are onStartupFinished activated, you compete with vscode for start up time and as a result, you hurt vscode's full startup time in the process.
It's better to be reactive and only activate when the user interacts with your extension:
- via a command
- via a view being visible
To Reproduce Steps to reproduce the behavior:
- Go to vscode.dev
- install codetour
- reload the window
- codetour is activated
Expected behavior It shouldn't activate until needed.
Additional context The line in the package.json is here: https://github.com/microsoft/codetour/blob/main/package.json#L34
Activation events for your reference (even though I know you know where these are) https://code.visualstudio.com/api/references/activation-events
This project seems to be abandoned, I can't even get a code review on the feature I've contributed. I wouldn't expect this to get changed unless you write the change yourself. Perhaps we should fork the project and release our fork to the vs code marketplace?
