[SDK/Service] OAuthPrompt should complete with null token and error when a signin flow is cancelled
Issue
Today when a bot user clicks the login button on an oauth card , the signin process involves opening a browser for login. If the user cancels this flow (by not granting consent for instance), or other failure, the flow fails in the browser and the bot is never notified. For an example see issue - https://github.com/microsoft/botframework-sdk/issues/6137
Proposed change
- Update the OAuthPrompt related contracts to support a "failure reason"
- Update service code to return the proper contract when an error happens (this should not apply to the "test connection" flow in the portal)
Component Impact
- SDK (OAuthPrompt code and contracts)
- Service update
Customer Impact
More seamless flow in case of user login failure (See referred issue above)
Tracking Status
Dotnet SDK TODO
- [ ] PR
- [ ] Merged
Javascript SDK TODO
- [ ] PR
- [ ] Merged
Python SDK TODO
- [ ] PR
- [ ] Merged
Java SDK TODO
- [ ] PR
- [ ] Merged
Samples TODO
- [ ] PR
- [ ] Merged
Docs TODO
- [ ] PR
- [ ] Merged
Tools TODO
- [ ] PR
- [ ] Merged
@Jeffders @carlosscastro @stevengum @EricDahlvang thoughts?
Hi @swagatmishra2007, were you able to get any consensus here?
Looks like a good plan to me.