botframework-components icon indicating copy to clipboard operation
botframework-components copied to clipboard

feat: Added timeout support for some Telephony package's dialogs

Open luislera opened this issue 2 years ago • 3 comments

Purpose

This PR includes timeout support for the following dialogs:

  • Aggregate DTMF (n)
  • Aggregate input Regex
  • Aggregate DTMF (#)

The timeout timer will be initialized when the dialog begins. If the user sends a valid input but does not meet the batch length, termination char or regex expression, the timer will start again.

Changes

  • Added the Timeout, Default Value and Default Value Response properties
  • Updated the schema files
  • Updated the package README file

Tests

No tests added. The existing tests were executed successfully.

imagen

#minor

luislera avatar Mar 08 '23 19:03 luislera

@stevengum , @ninilang - can you review this? Has added the additional experience changes we discussed (splitting the default message from the default value, supporting speech field, etc).

jameslew avatar Mar 22 '23 15:03 jameslew

Is this still active?

tracyboehrer avatar May 16 '23 16:05 tracyboehrer

Is this still active?

Hi Tracy, I think it is still pending the PR's revision.

luislera avatar May 16 '23 18:05 luislera