botbuilder-python
botbuilder-python copied to clipboard
Core package includes aiohttp-specific modules under core/integration instead of aiohttp integration package
Version
v4.17.0
Describe the bug
aiohttp-specific modules are included inside the core package under core/integration, which couples botbuilder-core to aiohttp despite having a separate aiohttp integration package.
Affected files:
- libraries/botbuilder-core/botbuilder/core/integration/aiohttp_channel_service.py
- libraries/botbuilder-core/botbuilder/core/integration/aiohttp_channel_service_exception_middleware.py
This placement makes the core package framework-specific instead of framework-agnostic and can force unnecessary dependencies or create version conflicts for users not using aiohttp.
To Reproduce
- Install botbuilder-core.
- Inspect the package contents (e.g., site-packages/botbuilder/core/integration/).
- Observe aiohttp-specific modules present in the core package path noted above.
Expected behavior
- aiohttp-specific code lives in the aiohttp integration package (e.g., integration/aiohttp).
- botbuilder-core remains transport/framework-agnostic with clear extension points for integrations.
Additional context
Encountered while trying to integrate botbuilder into FastAPI API.