botbuilder-python icon indicating copy to clipboard operation
botbuilder-python copied to clipboard

port: [#6099] Remove low impact FxCop exclusions - Rule CA1801 (#6181)

Open github-actions[bot] opened this issue 4 years ago • 0 comments

The changes in [#6099] Remove low impact FxCop exclusions - Rule CA1801 (#6181) may need to be ported to maintain parity with microsoft/botbuilder-dotnet.

Addresses #6099 #minor

Description

This PR removes the exclusions of the FxCop rule CA1801 (Review unused parameters).

Note: we updated obsolete methods and deprecated classes even though they shouldn't be part of the v5 release.

Detailed Changes

  • Removed cancellationToken parameter in:
    • FillLuisEventPropertiesAsync method of LuisRecognizer class.
    • FillQnAEventAsync method of QnAMaker class.
    • GetPropertyValueAsync, DeletePropertyValueAsync, and SetPropertyValueAsync methods of BotState class.
  • Removed ChannelId parameter of the MaxActionTitleLength method in Channel class.
  • Removed description parameter of one of the AssertReply methods in TestFlow class.
  • Removed exclusions in obsolete methods of AppCredentials class.
  • Removed multiplier parameter of the WithJitter method in TimeSpanExtensions class.
  • Removed deprecated parameter addJwtTokenRefresher in ConnectorClientEx class.
  • Removed customHeaders parameter in deprecated class OAuthClientOld.
  • Removed customHeaders parameter in FetchParticipantWithHttpMessagesAsync method of TeamsOperations class.
  • Removed offset parameter in Deserialize method of HeaderSerializer class.
  • Updated unit tests to the new signature of the methods.

Testing

This image shows the tests passing after the changes. image

Please review and, if necessary, port the changes.

github-actions[bot] avatar Feb 09 '22 14:02 github-actions[bot]