botbuilder-python
botbuilder-python copied to clipboard
port: [#6099] Remove low impact FxCop exclusions - Rule CA1801 (#6181)
The changes in [#6099] Remove low impact FxCop exclusions - Rule CA1801 (#6181) may need to be ported to maintain parity with microsoft/botbuilder-dotnet.
Addresses #6099 #minorDescription
This PR removes the exclusions of the FxCop rule CA1801 (Review unused parameters).
Note: we updated obsolete methods and deprecated classes even though they shouldn't be part of the v5 release.
Detailed Changes
- Removed
cancellationTokenparameter in:
- FillLuisEventPropertiesAsync method of LuisRecognizer class.
- FillQnAEventAsync method of QnAMaker class.
- GetPropertyValueAsync, DeletePropertyValueAsync, and SetPropertyValueAsync methods of BotState class.
- Removed
ChannelIdparameter of the MaxActionTitleLength method in Channel class.- Removed
descriptionparameter of one of the AssertReply methods in TestFlow class.- Removed exclusions in obsolete methods of AppCredentials class.
- Removed
multiplierparameter of the WithJitter method in TimeSpanExtensions class.- Removed deprecated parameter
addJwtTokenRefresherin ConnectorClientEx class.- Removed
customHeadersparameter in deprecated class OAuthClientOld.- Removed
customHeadersparameter in FetchParticipantWithHttpMessagesAsync method of TeamsOperations class.- Removed
offsetparameter in Deserialize method of HeaderSerializer class.- Updated unit tests to the new signature of the methods.
Testing
This image shows the tests passing after the changes.
Please review and, if necessary, port the changes.
