botbuilder-python icon indicating copy to clipboard operation
botbuilder-python copied to clipboard

port: [#6023] Test explorer should not start Azure emulator when loading tests (#6078)

Open github-actions[bot] opened this issue 4 years ago • 0 comments

The changes in [#6023] Test explorer should not start Azure emulator when loading tests (#6078) may need to be ported to maintain parity with microsoft/botbuilder-dotnet.

Fixes #6023

Description

This PR disables the CosmosDB tests from running by skipping them in the IgnoreOnNoEmulatorFact class. It also adds a description explaining the reasons why they are being disabled.

Specific Changes

  • Removed HasEmulator lazy variable from CosmosDbPartitionStorageFixture, CosmosDbStorageTests and IgnoreOnNoEmulatorFact to prevent the Emulator security window to appear.
  • Updated the IgnoreOnNoEmulatorFact skip message with information related to why the tests are skipped and where the tests are going to be moved.

Testing

The following image shows the CosmosDB tests being always skipped. imagen

Please review and, if necessary, port the changes.

github-actions[bot] avatar Feb 07 '22 17:02 github-actions[bot]