botbuilder-python icon indicating copy to clipboard operation
botbuilder-python copied to clipboard

port: Upgrade named pipes to use new streaming library. (#6147)

Open github-actions[bot] opened this issue 4 years ago • 0 comments

The changes in Upgrade named pipes to use new streaming library. (#6147) may need to be ported to maintain parity with microsoft/botbuilder-dotnet.

Fixes #6003

Description

This change upgrades Named Pipes to use new Microsoft.Bot.Connector.Streaming library in v4. This will enable the deprecation of the old Microsoft.Bot.Streaming library in v5.

Specific Changes

  • Refactored common code for streaming transport, streaming connection, and streaming client into respective abstract classes: StreamingTransport, StreamingConnection, and StreamingTransportClient.
  • Created new named pipe classes to derive from the above abstract classes: NamedPipeTransport, NamedPipeStreamingConnection, and NamedPipeClient.
  • Refactored the corresponding web socket classes.

Testing

Verified the following scenarios for CloudAdapter, and BotFrameworkHttpAdapter:

  • Echo sample with Named Pipes on localhost, and DirectLine ASE
  • Skill sample with Named Pipes on localhost, and DirectLine ASE
  • Regression tested web socket functionality for echo sample and skill sample
  • Unit tests passed

Please review and, if necessary, port the changes.

github-actions[bot] avatar Feb 03 '22 18:02 github-actions[bot]