botbuilder-python
botbuilder-python copied to clipboard
port: Upgrade named pipes to use new streaming library. (#6147)
The changes in Upgrade named pipes to use new streaming library. (#6147) may need to be ported to maintain parity with microsoft/botbuilder-dotnet.
Fixes #6003Description
This change upgrades Named Pipes to use new
Microsoft.Bot.Connector.Streaminglibrary in v4. This will enable the deprecation of the oldMicrosoft.Bot.Streaminglibrary in v5.Specific Changes
- Refactored common code for streaming transport, streaming connection, and streaming client into respective abstract classes:
StreamingTransport,StreamingConnection, andStreamingTransportClient.- Created new named pipe classes to derive from the above abstract classes:
NamedPipeTransport,NamedPipeStreamingConnection, andNamedPipeClient.- Refactored the corresponding web socket classes.
Testing
Verified the following scenarios for CloudAdapter, and BotFrameworkHttpAdapter:
- Echo sample with Named Pipes on localhost, and DirectLine ASE
- Skill sample with Named Pipes on localhost, and DirectLine ASE
- Regression tested web socket functionality for echo sample and skill sample
- Unit tests passed
Please review and, if necessary, port the changes.