botbuilder-python icon indicating copy to clipboard operation
botbuilder-python copied to clipboard

port: [#5713] Dialogs.Declarative.Tests hang and give no message. (#5993)

Open github-actions[bot] opened this issue 4 years ago • 0 comments

The changes in [#5713] Dialogs.Declarative.Tests hang and give no message. (#5993) may need to be ported to maintain parity with microsoft/botbuilder-dotnet.

Fixes #5713

Description

This PR fixes an issue when BotFramework-CLI is not installed in the Operative System (OS), the tests hang while installing the library. Instead, when it isn't installed, the tests will fail, warning the user to install the library.

Specific Changes

  • Added validation to throw the error when the mergeCommand fails.
  • Removed condition to install or update the @microsoft/botframework-cli library.
  • Reordered the code to accommodate the changes, the logic remains the same, without the installation of the library.

Testing

The following images show when there is no bf-cli install, and when there is. image

Please review and, if necessary, port the changes.

github-actions[bot] avatar Jan 24 '22 21:01 github-actions[bot]