botbuilder-python icon indicating copy to clipboard operation
botbuilder-python copied to clipboard

port: [#6019] Remove redundant project dependencies from AI Recognizers (#6067)

Open github-actions[bot] opened this issue 4 years ago • 0 comments

The changes in [#6019] Remove redundant project dependencies from AI Recognizers (#6067) may need to be ported to maintain parity with microsoft/botbuilder-dotnet.

Fixes #6019

Note: The same dependency structure was corroborated for JavaScript and Python. Only JavaScript has the similar case as DotNet, whereas Python doesn't.

Description

This PR removes redundant dependencies for Dialogs.Adaptive, AI.Orchestrator and AI.QnA.

Specific Changes

  • Dialogs.Adaptive
    • Removed AdaptiveExpressions dependency reference from <ProjectReference/> and <PackageReference/>.
  • AI.Orchestrator
    • Removed Microsoft.Bot.Builder.Dialogs dependency reference from <ProjectReference/>.
  • AI.QnA
    • Removed AdaptiveExpressions and Microsoft.Bot.Builder dependencies' references from <ProjectReference/> and <PackageReference/>.

Testing

The following image shows the CI pipeline running successfully after the changes. image

Please review and, if necessary, port the changes.

github-actions[bot] avatar Jan 20 '22 01:01 github-actions[bot]