port: Add ShowSignInLink to OAuthPromptSettings (#5906)

Open github-actions[bot] opened this issue 4 years ago • 0 comments

The changes in Add ShowSignInLink to OAuthPromptSettings (#5906) may need to be ported to maintain parity with microsoft/botbuilder-dotnet.

Fixes #5887
Description

The decision of showing a SignIn link depends on the channel Id in use. This change adds an optional value to OAuthPromptSettings to override the default implementation in https://github.com/microsoft/botbuilder-dotnet/blob/e176bb576105538cd179187f4c19b2818d2578e7/libraries/Microsoft.Bot.Builder.Dialogs/Prompts/OAuthPrompt.cs#L602

Testing

A data driven test is being added that verify the link value is calculated correctly:

Please review and, if necessary, port the changes.

Oct 07 '21 18:10 github-actions[bot]