botbuilder-python icon indicating copy to clipboard operation
botbuilder-python copied to clipboard

port: Fix first activity from bot to user has fake replyToId value (#5313)

Open github-actions[bot] opened this issue 4 years ago • 0 comments

The changes in Fix first activity from bot to user has fake replyToId value (#5313) may need to be ported to maintain parity with microsoft/botbuilder-dotnet.

Fixes #5310

Description

When the activity is the first one of the conversation and it's sent from bot to user, the ReplyToId was assigned to the bogus ConversationUpdate activity's id. The fix is to not assign the bogus ReplyToId if previous activity is the ConversationUpdate activity

Specific Changes

  • Do not assign ReplyToId if conversantionReference is from ConversationUpdate activity
  • Add test tests to test the changes

Testing

Tests are added

Please review and, if necessary, port the changes.

github-actions[bot] avatar Jun 08 '21 00:06 github-actions[bot]