botbuilder-python icon indicating copy to clipboard operation
botbuilder-python copied to clipboard

port: move allowed callers and skill conversation factory (#5286)

Open github-actions[bot] opened this issue 4 years ago • 0 comments

The changes in move allowed callers and skill conversation factory (#5286) may need to be ported to maintain parity with microsoft/botbuilder-dotnet.

Moving a couple of classes out of adaptive runtime and into bot.builder and connector. And making these classes public.

We duplicate this code in a number of places: samples and tests.

The allowedcallers code should depend on BotFrameworkAuthentication rather than GetAppIdFromClaims directly, though that might not be critical path.

Note the samples and some test code derived from it make the concepts of allowed callers and allowed skills distinct - even though they are the same validation of appId. And they therefore read different configuration for each. The adaptive runtime didn't follow this pattern and so we only need AllowedCallersClaimsValidator and not AllowedSkillsClaimsValidator.

Please review and, if necessary, port the changes.

github-actions[bot] avatar Mar 09 '21 17:03 github-actions[bot]