botbuilder-js
botbuilder-js copied to clipboard
microsoft
fix: [botframework-streaming] Some named pipe tests are not passing after fixing their inconclusiveness
Fixes #4462
Description
This PR fixes the NamedPipe unit tests that weren't passing. It adds code to the receive method of the NamedPipeTransport class to handle null and destroyed sockets. Additionally, it updates the transport unit test to be compatible with the new changes and the client-server tests to make the connection correctly.
Specific Changes
- New condition in the receive method of the NamedPipeTransport class to handle null and destroyed sockets.
- Updated 'throws then reading from a dead socket' unit test to be compatible with the changes of the receive method.
- Updated client and server 'sends without throwing' unit tests to make the connection correctly.
Testing
Pull Request Test Coverage Report for Build 5334935081
- 5 of 5 (100.0%) changed or added relevant lines in 1 file are covered.
- 1 unchanged line in 1 file lost coverage.
- Overall coverage decreased (-0.02%) to 84.484%
| Files with Coverage Reduction | New Missed Lines | % |
|---|---|---|
| libraries/botframework-streaming/src/namedPipe/namedPipeTransport.ts | 1 | 96.36% |
| <!-- | Total: | 1 |
| Totals | |
|---|---|
| Change from base Build 5222839148: | -0.02% |
| Covered Lines: | 20037 |
| Relevant Lines: | 22480 |
💛 - Coveralls
These tests are failing due to missing Azure resources. Solution pending.
