bedrock icon indicating copy to clipboard operation
bedrock copied to clipboard

Upgrade to [email protected]

Open evanlouie opened this issue 6 years ago • 1 comments

As a: spk developer

I want: to the azure-devops-node-api library (currently pinned to 9.0.1) to 10.0.0

So that: we no longer have a postinstall job to apply a patch (patches/001-azure-devops-node.patch) that was used to fix the way the library was fetching its own version number and breaking out webpack builds. The application of this patch has been shown to be quite flaky in the past.

Describe the solution you'd like:

  • upgrade to azure-devops-node-api@10.0.0

Acceptance Criteria:

  • run yarn add azure-devops-node-api to install the latest version
  • ensure that no breakages have been caused from the upgrade
    • one breakage found from initial testing: https://github.com/CatalystCode/spk/blob/master/src/lib/pipelines/variableGroup.ts#L178
      • the addVariableGroup method now accepts different number of parameters
  • remove the postinstall script from package.json
  • ensure that yarn build succeeds

Describe alternatives you've considered: N/A

Additional context:

  • We discovered the bug in the library back in October and raised an issue back then. A fix was created quite quickly but only recently as a new release been cut.

Does this require updates to documentation?: No

evanlouie avatar Jan 06 '20 20:01 evanlouie

Marking as blocked due to https://github.com/microsoft/azure-devops-node-api/issues/369

andrebriggs avatar Jan 15 '20 18:01 andrebriggs