bedrock icon indicating copy to clipboard operation
bedrock copied to clipboard

Create fab definition for dashboard

Open samiyaakhtar opened this issue 5 years ago • 1 comments

As a: developer

I want: dashboard helm chart to be included in the default HLD created by spk

So that: the dashboard is already present on the cluster

Describe the solution you'd like: Post completion of https://github.com/microsoft/bedrock/issues/967, it would be ideal for users of bedrock to not have to manually setup the dashboard in their cluster. However, some thinking is needed around how env vars would be passed in to the helm install command (for the vars needed by dashboard) during manifest generation or fab generate, since these env vars have secrets that are not written in the chart's values.yaml.

  • [ ] Investigate and provide a fab definition for spektate
  • [ ] Include this HLD in default HLD created by spk hld commands - TODO: make this a separate issue

Acceptance Criteria: Dashboard is easy to setup on the cluster

Describe alternatives you've considered: Manually install via helm chart

Additional context:

Does this require updates to documentation?: Yes

samiyaakhtar avatar Mar 13 '20 13:03 samiyaakhtar

@samiyaakhtar I think there should be an option to enable/disable this. Maybe by default it is not included but if a user adds the flag --dashboard to the spk hld init command then this feature will be enabled.

  1. So spk hld init --dashboard will add a reference to Spektate when the user sets up the HLD.
  2. This method is idempotent so if the Spektate dashboard exists in the HLD no change will happen.

Thoughts? cc @mtarng

andrebriggs avatar Mar 17 '20 07:03 andrebriggs