beachball icon indicating copy to clipboard operation
beachball copied to clipboard

With groupChanges, existing change file for branch should be updated if it exists

Open ecraig12345 opened this issue 4 years ago • 1 comments

With the groupChanges option in a monorepo, beachball will currently create a new file each time you run yarn change (with additional changed packages) even if a multi-package change file already existed for that branch.

Repro:

  1. Set groupChanges: true in beachball config
  2. Change some packages and commit
  3. Run beachball to create a change file
  4. Change some more packages and commit
  5. Run beachball again

Actual: a new change file is created

Expected: new changes should be added to the existing change file for that branch

Important edge case: must verify that the existing file is for multiple packages (has changes key) before adding to it. Otherwise fall back to creating a new file. (This is important for repos which recently enabled groupChanges and may still have open PR branches with single-package change files.)

cc @jcreamer898 -- this is more of an enhancement than a bug, but if you have time and don't mind working on it that would be great (not sure if/when I'd get to it)

ecraig12345 avatar Sep 27 '21 23:09 ecraig12345

OoOoOo, that's interesting! Let me see what I can do. Sorry I just saw this. I need to re-enable email notifications for github repos. Haha.

jcreamer898 avatar Oct 29 '21 19:10 jcreamer898