azurelinux icon indicating copy to clipboard operation
azurelinux copied to clipboard

Bring back python-botocore and fix build failure.

Open Sumynwa opened this issue 3 years ago • 1 comments

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • [x] The toolchain has been rebuilt successfully (or no changes were made to it)
  • [x] The toolchain/worker package manifests are up-to-date
  • [x] Any updated packages successfully build (or no packages were changed)
  • [x] Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • [x] Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • [x] All package sources are available
  • [x] cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/tools/cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • [x] LICENSE-MAP files are up-to-date (./SPECS/LICENSES-AND-NOTICES/data/licenses.json, ./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md, ./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)
  • [x] All source files have up-to-date hashes in the *.signatures.json files
  • [x] sudo make go-tidy-all and sudo make go-test-coverage pass
  • [x] Documentation has been updated to match any changes to the build system
  • [x] Ready to merge

Summary
  • Bring back reverted commit c48477cee344f9733dc423c73daef88f02d9404b
  • Fix build issues by moving BR on python3-pip from check section to general BR section. This is because the build pyproject-rpm-macro 'pyproject-wheel' uses 'pip wheel' to generate project wheel artifacts. This requires dependency on pip even when building without check section
Change Log
  • Adding python-botocore Spec in CBL-Mariner
  • Fix build issues by moving BR on python3-pip from check section to general BR section.
  • Fix check section. Add BR dependencies.
Does this affect the toolchain?

NO

Associated issues
  • #xxxx
Links to CVEs
  • https://nvd.nist.gov/vuln/detail/CVE-YYYY-XXXX
Test Methodology
  • Local Build

Sumynwa avatar Aug 09 '22 15:08 Sumynwa

Yes, the test (%check) sections pass for this package.

Sumynwa avatar Aug 29 '22 09:08 Sumynwa