Enhanced Type Hints for Improved Readability and Maintainability: Addressing Type Mismatch in `query_quadrant` Return Statement
Why are these changes needed?
-
I've updated the type hints of the
*_utilsto improve code readability, maintainability, and to facilitate static type checking. This enhancement will make it easier for developers to understand the expected types of parameters and return values, reducing the likelihood of type-related errors and improving overall code quality. -
updated the
query_quadrantinqdrant_retrieve_user_proxy_agent.py, the return statement doesn't match with the type mentioned. otherwise returns adict, could be a problem for the developer to usequery_quadrant.
Related issue number
No issue is related.
Checks
- [ ] I've included any doc changes needed for https://microsoft.github.io/autogen/. See https://microsoft.github.io/autogen/docs/Contribute#documentation to build and test documentation locally.
- [ ] I've added tests (if relevant) corresponding to the changes introduced in this PR.
- [ ] I've made sure all auto checks have passed.
@thinkall i think we can merge this PR now? please review the PR.
@sonichi @ekzhu
⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.
Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.
🔎 Detected hardcoded secret in your pull request
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 10404662 | Triggered | Generic CLI Secret | e7bd3d5372548507bfdae515b9a0c56e8bd10bc8 | .github/workflows/dotnet-release.yml | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Some tests failed: https://github.com/microsoft/autogen/actions/runs/8886069444/job/24398827078?pr=2452
I'll check on them. Thanks
@sonichi i've made the changes.
Could you please fix the test failures?
yeah working on it.
@sonichi ive made the changes, will open a new PR for the query_qdrant, might need to change some utils too. Thanks
@sonichi i've no idea why the compression test is failing, which isn't relevant to this PR. maybe because of the previous commits?
i made some changes in the test_compressible_agent, any suggestions would be greatly appreciated.
@yiranwu0 @WaelKarkoub @gagb is it time to retire compressible agent? Have we reached feature parity with the TransformMessages capability?
@yiranwu0 @WaelKarkoub @gagb is it time to retire compressible agent? Have we reached feature parity with the
TransformMessagescapability?
@sonichi I'm working on LLMLingua support, once that goes in, we should retire compressible agent. https://github.com/microsoft/autogen/pull/2225