Refactor convert_float()

Open riedgar-ms opened this issue 3 years ago • 4 comments

Refactor convert_float() into utils. Although the two functions are slightly different, it turns out that float("") also raises a ValueError.

Oct 13 '22 12:10 riedgar-ms

@slundberg @Harsha-Nori ?

Oct 18 '22 13:10 riedgar-ms

LGTM. One thought - several of your edits here are small formatting fixes like adding whitespace and changing a single quote to double quote. We should consider picking a code formatter which will make this easier as the project grows.

You may note that one of the commit comments features 'blacken' :-)

Oct 19 '22 00:10 riedgar-ms

Very cool, how did you run that? Is it part of Github Actions?

Oct 20 '22 02:10 nking-1

Ahhh no, I'm running it manually, just on files I feel I 'own' (whatever that means, exactly). I haven't dared run it on the full codebase yet (although I have seen how to exclude a particular commit from git blame so it doesn't wreck the history). As you know @Nking92 , black is rather opinionated.

Oct 20 '22 15:10 riedgar-ms