accessibility-insights-web icon indicating copy to clipboard operation
accessibility-insights-web copied to clipboard

Settings menu buttons have no hover state with high contrast theme set

Open pownkel opened this issue 3 years ago • 4 comments

Describe the bug

In the current Canary (2022.6.24.1419), when the "night sky" theme enabled in Windows, the settings menu buttons no longer have a visible hover state. This is a regression from the current production build. Other buttons in the extension still change color when hovered.

To Reproduce Steps to reproduce the behavior:

  1. In the Windows settings app, go to Accessibility > Contrast themes and enable the "Night sky" theme
  2. In Chrome, start an assessment or fastpass run with the Canary extension
  3. Select the gear in the upper right corner to open the settings menu
  4. Hover the cursor over the buttons in the menu

Expected behavior

The buttons should change visibly when hovered

Screenshots

In the current Canary build (2022.6.24.1419) with the "Settings" button hovered settings menu no hover state

In the Production build (2.32.0) with the "Settings button hovered settings menu bar prod hover state

Context (please complete the following information)

  • OS Name & Version: Windows 11 build 22000.739
  • AI-Web Version & Environment: Canary 2022.6.24.1419
  • Browser Version: Google Chrome 102.0.5005.115 (Official Build) (32-bit)
  • Target Page: any

Are you willing to submit a PR?

Yes

Did you search for similar existing issues?

Yes

pownkel avatar Jun 28 '22 00:06 pownkel

This issue has been marked as ready for team triage; we will triage it in our weekly review and update the issue. Thank you for contributing to Accessibility Insights!

ghost avatar Jun 28 '22 15:06 ghost

Edit: Most other buttons still change color when hovered. I've found similar issues in a few other popup menus. The first screenshot in each pair is from Canary, the second is from Prod.

  1. The Assessment "Start over" menu Start over menu with no hover color Start over menu with hover color

  2. The "export" split button in the Assessment "Export report" dialog Export button with no hover color Export button with hover color

  3. The top-left meatballs menu when the screen is shrunk to reflow size, only in Fastpass and only with the "start over" button (The "Export report" button changes text color to purple when hovered in both canary and prod) reflow menu with no hover color on start over reflow menu with hover color on start over

Interestingly, the buttons in the fastpass cards kebab menu do change color when hovered, although the styling is slightly different between Canary and Prod: Screenshot 2022-06-28 143333 Screenshot 2022-06-28 143446

And the Assessment reflow menu has identical hover states in both Canary and Prod ("Export report" is hovered in this screenshot, "Save Assessment" is always dark purple for some reason unless it's hovered): assessment reflow menu with hover state

pownkel avatar Jun 28 '22 21:06 pownkel

This may be a Fluent UI issue. The same behavior can be seen in the contextual menu samples at https://developer.microsoft.com/en-us/fluentui#/controls/web/contextualmenu (FluentUI v 8.94.3) image (image showing no hover indication when mouse hovering over Rename item)

peterdur avatar Sep 09 '22 17:09 peterdur

Rolling fluentui/react back to 8.49.6 (the version used in the previous release) seems to restore the hover behavior.

peterdur avatar Sep 09 '22 17:09 peterdur

Verified in production version 2.37.3

peterdur avatar Mar 30 '23 20:03 peterdur