Add MddGetPackageGraphRevisionId() + M.W.AM.DynamicDependency.PackageDependency.PackageGraphRevisionId API Spec

[DrusTheAxe]

Add MddGetPackageGraphRevisionId() (Flat-C API) and PackageGraphRevisionId property (WinRT API), for alignment with Windows 11 API / terminology.

GenerationId is soft-deprecated (predecessor equivalent to PackageGraphRevisionId still supported but will go away in a future release).

Also corrected spec missing updates:

• Corrected missing changes per previous API Review and implementation
• Added missing contracts (added in WinAppSDK 1.1)

https://task.ms/41077950

[DrusTheAxe]

We're doing an "email review" of this - please leave your comments in the PR by 5pm Seattle time, 2022-08-26. @DrusTheAxe will address feedback in future updates.

[DrusTheAxe]

Is it on purpose that we change generation => revision id but make no mention of the "soft deprecation?"

Are you referring to a specific line?

[EHO-makai]

No, it seems like most of the edits just change generation => revision. But no mention is made of what you're supposed to do if you had previously used generation. I'm not asking for a change here necessarily, just wondering if silently doing a "replace" here is what you intended / OK.

[DrusTheAxe]

No, it seems like most of the edits just change generation => revision. But no mention is made of what you're supposed to do if you had previously used generation.

2 words for the same thing.

Was originally called GenerationId in Windows (internal) and then WinAppSDK DynDep API Review. Windows had no public API to get that value so we fixed that with a new public API (GetPackageGraphRevisionId) per API Review, which recommended using the term 'revision id' instead of 'generation id'.

This merely updates WinAppSDK to support consist lingo with Windows. Compat's retained for now; breaking changes deferred to vFuture when that's viable e.g. 2.0

I'm not asking for a change here necessarily, just wondering if silently doing a "replace" here is what you intended / OK.

Yes. Given it's the same thing, the GetGeneration doc-comments point you to GetRevision, and it's open source so anyone who looks can see it's the same thing¹ I didn't see a need to belabor the point. I expect the release notes and docs will mention this.

¹ The implementation is literally 1-liners UINT32 MddGetGenerationId() { return MddGetPackageGraphRevisionId(); })

[DrusTheAxe]

/azp run

[azure-pipelines[bot]]

Azure Pipelines successfully started running 1 pipeline(s).