WindowsAppSDK icon indicating copy to clipboard operation
WindowsAppSDK copied to clipboard

Don't install x64 framework package on Windows 10 ARM64 devices as it…

Open sachintaMSFT opened this issue 3 years ago • 12 comments

Don't install x64 framework package on Windows 10 ARM64 devices. Win 10 ARM64 doesn't support x64 apps. Tested IsWindows10_21H2OrGreater API on Windows 10 and Windows 11 and works as expected.

And fixed an unused variable deploymentOptions in two places (in one place, it is used now. In another, it is removed altogether).

https://github.com/microsoft/WindowsAppSDK/issues/2564

sachintaMSFT avatar Aug 10 '22 01:08 sachintaMSFT

/azp run

sachintaMSFT avatar Aug 10 '22 01:08 sachintaMSFT

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Aug 10 '22 01:08 azure-pipelines[bot]

/azp run

sachintaMSFT avatar Aug 10 '22 18:08 sachintaMSFT

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Aug 10 '22 18:08 azure-pipelines[bot]

/azp run

sachintaMSFT avatar Aug 11 '22 01:08 sachintaMSFT

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Aug 11 '22 01:08 azure-pipelines[bot]

This seems very fragile. If downlevel gets serviced with these APIs, will all of this behave as expected?

riverar avatar Aug 11 '22 05:08 riverar

This seems very fragile. If downlevel gets serviced with these APIs, will all of this behave as expected? Even if suppose the GetMachineTypeAttributes get serviced downlevel, it will still work as expected. Because I am not only checking if the API is available BUT we are also calling the API to check applicability of a given architecture compatibility on the device.

Updated comments in the code as well to reflect this.

sachintaMSFT avatar Aug 11 '22 16:08 sachintaMSFT

/azp run

sachintaMSFT avatar Aug 11 '22 19:08 sachintaMSFT

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Aug 11 '22 19:08 azure-pipelines[bot]

/azp run

sachintaMSFT avatar Aug 11 '22 21:08 sachintaMSFT

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Aug 11 '22 21:08 azure-pipelines[bot]