Windows-rust-driver-samples icon indicating copy to clipboard operation
Windows-rust-driver-samples copied to clipboard

ci: add concurrency control to workflows

Open svasista-ms opened this issue 6 months ago • 3 comments

Closes #38

Cancels in-progress workflows/jobs for the build workflow when new events are triggered on the same branch

Summary of changes:

  • Added concurrency section to the build.yaml workflow
  • Added cancel-in-progress: true to cancel any currently running job or workflow in the same concurrency group.

svasista-ms avatar Aug 04 '25 12:08 svasista-ms

The build pipeline is failing due to the following error. Once it is fixed, I think this one is good to be merged.

stderr:
error: unnecessary parentheses around closure body
  --> rust-env-update.rs:21:25
   |
21 |         .map(|(key, _)| (key)),
   |                         ^   ^
   |
   = note: `-D unused-parens` implied by `-D warnings`
   = help: to override `-D warnings` add `#[allow(unused_parens)]`
help: remove these parentheses
   |
21 -         .map(|(key, _)| (key)),
21 +         .map(|(key, _)| key),
   |

krishnakumar4a4 avatar Aug 19 '25 02:08 krishnakumar4a4

The build pipeline is failing due to the following error. Once it is fixed, I think this one is good to be merged.

stderr:
error: unnecessary parentheses around closure body
  --> rust-env-update.rs:21:25
   |
21 |         .map(|(key, _)| (key)),
   |                         ^   ^
   |
   = note: `-D unused-parens` implied by `-D warnings`
   = help: to override `-D warnings` add `#[allow(unused_parens)]`
help: remove these parentheses
   |
21 -         .map(|(key, _)| (key)),
21 +         .map(|(key, _)| key),
   |

I’ve noticed that this error originates from the wdk-build dependency. Although the fix has been merged and is available on the main branch, a release needs to be created before we can use it here.

krishnakumar4a4 avatar Aug 19 '25 04:08 krishnakumar4a4

The build pipeline is failing due to the following error. Once it is fixed, I think this one is good to be merged.

stderr:
error: unnecessary parentheses around closure body
  --> rust-env-update.rs:21:25
   |
21 |         .map(|(key, _)| (key)),
   |                         ^   ^
   |
   = note: `-D unused-parens` implied by `-D warnings`
   = help: to override `-D warnings` add `#[allow(unused_parens)]`
help: remove these parentheses
   |
21 -         .map(|(key, _)| (key)),
21 +         .map(|(key, _)| key),
   |

I’ve noticed that this error originates from the wdk-build dependency. Although the fix has been merged and is available on the main branch, a release needs to be created before we can use it here.

Yes @krishnakumar4a4, this PR can't be merged until a new version of wdk-build is published.

svasista-ms avatar Aug 19 '25 07:08 svasista-ms