microsoft
Scans failing with latest commit d85357185357a28fd8d72b86b477d595855a0d93
We are using Windows-Driver-Developer-Supplemental-Tools query pack to perform codeql scan for our drivers. We pick latest and the greatest of this repo from main line since there are no releases or tagged versions available. After merge of commit d85357185357a28fd8d72b86b477d595855a0d93 last night in this repo, we are observing failures in our scans -
[Glob found 0 file given match C:\OWR\Tools\CodeQL-CLI\codeql-queries**\windows_driver_mustfix.qls.
I would request at the very least this repo to have releases or tags which folks can consider stable and rely on. Any changes on mainline are released as tags periodically and provide details of breaking changes in CHANGELOG.md or something like that.
@PratibhaNatani Thanks for bringing this to our attention. Releases/versions are handled using the published CodeQL Pack available here. I would recommend using the packs over cloning the repo directly.
As you pointed out, a breaking change occurred with the windows_driver_mustfix.qls suite file. The equivalent file now would be src/windows-driver-suites/mustfix.qls. You can reference this file relative to the pack during analysis: "microsoft/windows-drivers:windows-driver-suites/mustfix.qls"
I will work on adding some kind of change log to the repo to better notify of any breaking changes.
