TypeScript icon indicating copy to clipboard operation
TypeScript copied to clipboard
verified publisher icon microsoft

Fix #50869, only cache calculated type for non-context sensitive parameters

Open weswigham opened this issue 3 years ago • 16 comments

Fixes #50869

weswigham avatar Sep 27 '22 21:09 weswigham

@typescript-bot perf test this

weswigham avatar Sep 27 '22 21:09 weswigham

Heya @weswigham, I've started to run the perf test suite on this PR at 62872267c5a6539e0f8083a50c816b671ce43e67. You can monitor the build here.

Update: The results are in!

typescript-bot avatar Sep 27 '22 21:09 typescript-bot

@typescript-bot test this @typescript-bot test top100 @typescript-bot user test this

DanielRosenwasser avatar Sep 27 '22 22:09 DanielRosenwasser

Heya @DanielRosenwasser, I've started to run the extended test suite on this PR at 62872267c5a6539e0f8083a50c816b671ce43e67. You can monitor the build here.

typescript-bot avatar Sep 27 '22 22:09 typescript-bot

Heya @DanielRosenwasser, I've started to run the diff-based top-repos suite on this PR at 62872267c5a6539e0f8083a50c816b671ce43e67. You can monitor the build here.

Update: The results are in!

typescript-bot avatar Sep 27 '22 22:09 typescript-bot

Heya @DanielRosenwasser, I've started to run the diff-based user code test suite on this PR at 62872267c5a6539e0f8083a50c816b671ce43e67. You can monitor the build here.

Update: The results are in!

typescript-bot avatar Sep 27 '22 22:09 typescript-bot

@weswigham The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - main..50976
Metric main 50976 Delta Best Worst
Angular - node (v10.16.3, x64)
Memory used 362,429k (± 0.02%) 362,465k (± 0.01%) +37k (+ 0.01%) 362,304k 362,537k
Parse Time 2.08s (± 0.64%) 2.09s (± 0.79%) +0.01s (+ 0.29%) 2.06s 2.13s
Bind Time 0.79s (± 1.22%) 0.78s (± 0.71%) -0.01s (- 0.89%) 0.77s 0.79s
Check Time 6.22s (± 0.58%) 6.23s (± 0.62%) +0.01s (+ 0.18%) 6.11s 6.28s
Emit Time 6.10s (± 0.54%) 6.08s (± 0.61%) -0.02s (- 0.39%) 6.00s 6.14s
Total Time 15.19s (± 0.43%) 15.18s (± 0.44%) -0.01s (- 0.04%) 15.06s 15.32s
Compiler-Unions - node (v10.16.3, x64)
Memory used 206,695k (± 0.37%) 206,123k (± 0.29%) -572k (- 0.28%) 203,738k 206,499k
Parse Time 0.83s (± 1.02%) 0.84s (± 0.66%) +0.01s (+ 0.84%) 0.82s 0.85s
Bind Time 0.47s (± 1.55%) 0.47s (± 1.24%) -0.00s (- 0.21%) 0.46s 0.48s
Check Time 8.36s (± 1.25%) 8.49s (± 0.64%) +0.13s (+ 1.55%) 8.35s 8.61s
Emit Time 2.46s (± 1.66%) 2.44s (± 0.95%) -0.01s (- 0.45%) 2.39s 2.50s
Total Time 12.12s (± 0.89%) 12.25s (± 0.52%) +0.13s (+ 1.07%) 12.08s 12.37s
Monaco - node (v10.16.3, x64)
Memory used 344,756k (± 0.02%) 344,863k (± 0.03%) +107k (+ 0.03%) 344,611k 345,071k
Parse Time 1.60s (± 0.60%) 1.61s (± 0.69%) +0.01s (+ 0.44%) 1.58s 1.63s
Bind Time 0.70s (± 0.52%) 0.70s (± 0.68%) +0.00s (+ 0.14%) 0.69s 0.71s
Check Time 6.22s (± 0.72%) 6.27s (± 0.65%) +0.05s (+ 0.85%) 6.18s 6.35s
Emit Time 3.25s (± 1.13%) 3.25s (± 0.57%) +0.00s (+ 0.09%) 3.21s 3.30s
Total Time 11.76s (± 0.37%) 11.83s (± 0.37%) +0.07s (+ 0.56%) 11.72s 11.93s
TFS - node (v10.16.3, x64)
Memory used 306,056k (± 0.02%) 306,120k (± 0.02%) +64k (+ 0.02%) 305,971k 306,221k
Parse Time 1.29s (± 0.48%) 1.30s (± 0.67%) +0.01s (+ 0.70%) 1.28s 1.31s
Bind Time 0.67s (± 0.83%) 0.67s (± 0.74%) +0.00s (+ 0.45%) 0.66s 0.68s
Check Time 5.50s (± 0.59%) 5.57s (± 0.90%) +0.06s (+ 1.14%) 5.48s 5.69s
Emit Time 3.40s (± 1.37%) 3.44s (± 0.91%) +0.04s (+ 1.03%) 3.33s 3.48s
Total Time 10.87s (± 0.57%) 10.98s (± 0.67%) +0.11s (+ 1.02%) 10.78s 11.13s
material-ui - node (v10.16.3, x64)
Memory used 458,069k (± 0.01%) 458,199k (± 0.02%) +130k (+ 0.03%) 458,074k 458,422k
Parse Time 1.82s (± 1.02%) 1.83s (± 0.70%) +0.01s (+ 0.55%) 1.80s 1.85s
Bind Time 0.58s (± 2.01%) 0.57s (± 2.17%) -0.00s (- 0.52%) 0.55s 0.60s
Check Time 15.64s (± 0.85%) 15.69s (± 0.88%) +0.05s (+ 0.29%) 15.47s 15.98s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 18.04s (± 0.75%) 18.10s (± 0.77%) +0.06s (+ 0.31%) 17.89s 18.39s
xstate - node (v10.16.3, x64)
Memory used 580,919k (± 0.01%) 580,962k (± 0.01%) +44k (+ 0.01%) 580,805k 581,164k
Parse Time 2.58s (± 0.26%) 2.60s (± 0.45%) +0.02s (+ 0.74%) 2.58s 2.63s
Bind Time 0.90s (± 0.40%) 0.90s (± 0.38%) -0.00s (- 0.11%) 0.90s 0.91s
Check Time 1.60s (± 0.58%) 1.60s (± 0.66%) +0.00s (+ 0.12%) 1.58s 1.63s
Emit Time 0.07s (± 4.13%) 0.07s (± 4.13%) 0.00s ( 0.00%) 0.07s 0.08s
Total Time 5.16s (± 0.27%) 5.19s (± 0.26%) +0.03s (+ 0.52%) 5.16s 5.22s
Angular - node (v12.1.0, x64)
Memory used 339,898k (± 0.08%) 339,936k (± 0.08%) +38k (+ 0.01%) 338,888k 340,161k
Parse Time 2.10s (± 0.92%) 2.10s (± 0.53%) +0.01s (+ 0.33%) 2.09s 2.14s
Bind Time 0.77s (± 0.98%) 0.78s (± 0.88%) +0.00s (+ 0.13%) 0.76s 0.79s
Check Time 5.89s (± 0.96%) 5.92s (± 0.75%) +0.03s (+ 0.49%) 5.82s 6.02s
Emit Time 6.38s (± 1.03%) 6.33s (± 0.72%) -0.05s (- 0.75%) 6.24s 6.43s
Total Time 15.13s (± 0.81%) 15.13s (± 0.49%) -0.01s (- 0.04%) 14.96s 15.33s
Compiler-Unions - node (v12.1.0, x64)
Memory used 193,704k (± 0.31%) 193,967k (± 0.45%) +263k (+ 0.14%) 191,470k 196,607k
Parse Time 0.83s (± 0.57%) 0.83s (± 0.69%) -0.00s (- 0.36%) 0.82s 0.84s
Bind Time 0.48s (± 1.29%) 0.48s (± 1.00%) -0.00s (- 0.42%) 0.47s 0.49s
Check Time 6.71s (± 0.67%) 6.75s (± 0.56%) +0.04s (+ 0.63%) 6.68s 6.86s
Emit Time 2.44s (± 0.95%) 2.44s (± 0.43%) +0.00s (+ 0.12%) 2.42s 2.46s
Total Time 10.46s (± 0.58%) 10.51s (± 0.46%) +0.04s (+ 0.41%) 10.41s 10.65s
Monaco - node (v12.1.0, x64)
Memory used 327,700k (± 0.03%) 327,777k (± 0.03%) +77k (+ 0.02%) 327,547k 327,930k
Parse Time 1.58s (± 1.09%) 1.59s (± 0.92%) +0.01s (+ 0.51%) 1.56s 1.63s
Bind Time 0.70s (± 0.71%) 0.70s (± 0.67%) +0.00s (+ 0.57%) 0.69s 0.71s
Check Time 5.83s (± 0.35%) 5.86s (± 0.49%) +0.03s (+ 0.46%) 5.80s 5.93s
Emit Time 3.32s (± 0.57%) 3.31s (± 0.53%) -0.01s (- 0.30%) 3.26s 3.34s
Total Time 11.43s (± 0.33%) 11.46s (± 0.47%) +0.03s (+ 0.26%) 11.35s 11.59s
TFS - node (v12.1.0, x64)
Memory used 290,613k (± 0.08%) 290,692k (± 0.07%) +79k (+ 0.03%) 289,899k 290,903k
Parse Time 1.30s (± 0.82%) 1.31s (± 0.46%) +0.01s (+ 0.77%) 1.29s 1.32s
Bind Time 0.67s (± 1.08%) 0.68s (± 2.11%) +0.01s (+ 1.49%) 0.66s 0.73s
Check Time 5.40s (± 0.71%) 5.43s (± 0.33%) +0.03s (+ 0.63%) 5.41s 5.48s
Emit Time 3.54s (± 1.17%) 3.50s (± 1.02%) -0.03s (- 0.93%) 3.44s 3.62s
Total Time 10.90s (± 0.57%) 10.92s (± 0.39%) +0.02s (+ 0.17%) 10.85s 11.05s
material-ui - node (v12.1.0, x64)
Memory used 437,450k (± 0.01%) 437,419k (± 0.01%) -31k (- 0.01%) 437,271k 437,498k
Parse Time 1.82s (± 0.48%) 1.84s (± 0.56%) +0.02s (+ 0.88%) 1.82s 1.86s
Bind Time 0.55s (± 0.94%) 0.55s (± 1.21%) +0.00s (+ 0.36%) 0.54s 0.57s
Check Time 12.74s (± 0.62%) 12.83s (± 0.68%) +0.09s (+ 0.67%) 12.65s 12.98s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 15.12s (± 0.52%) 15.22s (± 0.60%) +0.11s (+ 0.69%) 15.03s 15.40s
xstate - node (v12.1.0, x64)
Memory used 546,228k (± 0.01%) 546,234k (± 0.01%) +6k (+ 0.00%) 546,164k 546,308k
Parse Time 2.55s (± 0.68%) 2.56s (± 0.32%) +0.01s (+ 0.35%) 2.54s 2.57s
Bind Time 0.88s (± 0.67%) 0.89s (± 0.53%) +0.01s (+ 0.68%) 0.88s 0.90s
Check Time 1.48s (± 0.40%) 1.49s (± 0.45%) +0.00s (+ 0.20%) 1.47s 1.50s
Emit Time 0.07s (± 3.14%) 0.07s (± 0.00%) -0.00s (- 1.41%) 0.07s 0.07s
Total Time 4.98s (± 0.44%) 5.00s (± 0.32%) +0.02s (+ 0.40%) 4.97s 5.04s
Angular - node (v14.15.1, x64)
Memory used 338,104k (± 0.01%) 338,042k (± 0.01%) -61k (- 0.02%) 338,007k 338,094k
Parse Time 2.06s (± 0.55%) 2.06s (± 0.77%) +0.00s (+ 0.05%) 2.04s 2.10s
Bind Time 0.79s (± 0.59%) 0.80s (± 0.75%) +0.01s (+ 0.76%) 0.79s 0.81s
Check Time 5.89s (± 0.46%) 5.91s (± 0.52%) +0.02s (+ 0.34%) 5.86s 6.00s
Emit Time 6.27s (± 0.55%) 6.28s (± 0.60%) +0.01s (+ 0.21%) 6.18s 6.35s
Total Time 15.01s (± 0.34%) 15.05s (± 0.48%) +0.04s (+ 0.27%) 14.90s 15.19s
Compiler-Unions - node (v14.15.1, x64)
Memory used 190,776k (± 0.67%) 190,671k (± 0.71%) -106k (- 0.06%) 189,048k 196,009k
Parse Time 0.86s (± 0.55%) 0.86s (± 0.67%) +0.00s (+ 0.35%) 0.84s 0.87s
Bind Time 0.49s (± 1.06%) 0.49s (± 0.91%) -0.00s (- 0.20%) 0.48s 0.50s
Check Time 6.71s (± 0.44%) 6.74s (± 0.55%) +0.03s (+ 0.49%) 6.66s 6.86s
Emit Time 2.42s (± 1.38%) 2.39s (± 1.07%) -0.03s (- 1.20%) 2.35s 2.47s
Total Time 10.47s (± 0.49%) 10.48s (± 0.47%) +0.01s (+ 0.09%) 10.41s 10.65s
Monaco - node (v14.15.1, x64)
Memory used 326,571k (± 0.01%) 326,473k (± 0.00%) -98k (- 0.03%) 326,445k 326,511k
Parse Time 1.58s (± 0.35%) 1.59s (± 0.55%) +0.01s (+ 0.51%) 1.57s 1.61s
Bind Time 0.72s (± 0.55%) 0.73s (± 0.65%) +0.01s (+ 0.83%) 0.72s 0.74s
Check Time 5.72s (± 0.45%) 5.74s (± 0.43%) +0.02s (+ 0.40%) 5.68s 5.78s
Emit Time 3.37s (± 0.31%) 3.38s (± 0.66%) +0.01s (+ 0.27%) 3.32s 3.42s
Total Time 11.39s (± 0.24%) 11.44s (± 0.36%) +0.04s (+ 0.39%) 11.31s 11.52s
TFS - node (v14.15.1, x64)
Memory used 289,691k (± 0.01%) 289,686k (± 0.01%) -5k (- 0.00%) 289,587k 289,764k
Parse Time 1.30s (± 0.77%) 1.29s (± 0.63%) -0.00s (- 0.31%) 1.28s 1.31s
Bind Time 0.79s (± 1.68%) 0.79s (± 0.59%) 0.00s ( 0.00%) 0.78s 0.80s
Check Time 5.39s (± 0.55%) 5.40s (± 0.60%) +0.00s (+ 0.04%) 5.30s 5.46s
Emit Time 3.61s (± 1.14%) 3.66s (± 0.78%) +0.04s (+ 1.19%) 3.58s 3.72s
Total Time 11.10s (± 0.65%) 11.14s (± 0.51%) +0.04s (+ 0.34%) 10.94s 11.26s
material-ui - node (v14.15.1, x64)
Memory used 435,512k (± 0.04%) 435,608k (± 0.00%) +97k (+ 0.02%) 435,578k 435,634k
Parse Time 1.87s (± 0.55%) 1.87s (± 0.59%) +0.00s (+ 0.16%) 1.85s 1.90s
Bind Time 0.58s (± 0.57%) 0.58s (± 1.42%) +0.01s (+ 0.86%) 0.57s 0.61s
Check Time 12.83s (± 0.47%) 12.85s (± 0.39%) +0.02s (+ 0.13%) 12.72s 12.96s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 15.28s (± 0.41%) 15.31s (± 0.32%) +0.02s (+ 0.16%) 15.20s 15.43s
xstate - node (v14.15.1, x64)
Memory used 544,021k (± 0.00%) 544,036k (± 0.00%) +15k (+ 0.00%) 543,991k 544,069k
Parse Time 2.61s (± 0.83%) 2.62s (± 0.38%) +0.01s (+ 0.34%) 2.60s 2.63s
Bind Time 0.98s (± 1.19%) 0.99s (± 0.95%) +0.01s (+ 1.13%) 0.97s 1.01s
Check Time 1.51s (± 0.49%) 1.52s (± 0.60%) +0.01s (+ 0.40%) 1.50s 1.54s
Emit Time 0.07s (± 3.14%) 0.07s (± 0.00%) -0.00s (- 1.41%) 0.07s 0.07s
Total Time 5.17s (± 0.31%) 5.20s (± 0.39%) +0.03s (+ 0.54%) 5.16s 5.24s
System
Machine Namets-ci-ubuntu
Platformlinux 4.4.0-210-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v10.16.3, x64)
  • node (v12.1.0, x64)
  • node (v14.15.1, x64)
Scenarios
  • Angular - node (v10.16.3, x64)
  • Angular - node (v12.1.0, x64)
  • Angular - node (v14.15.1, x64)
  • Compiler-Unions - node (v10.16.3, x64)
  • Compiler-Unions - node (v12.1.0, x64)
  • Compiler-Unions - node (v14.15.1, x64)
  • Monaco - node (v10.16.3, x64)
  • Monaco - node (v12.1.0, x64)
  • Monaco - node (v14.15.1, x64)
  • TFS - node (v10.16.3, x64)
  • TFS - node (v12.1.0, x64)
  • TFS - node (v14.15.1, x64)
  • material-ui - node (v10.16.3, x64)
  • material-ui - node (v12.1.0, x64)
  • material-ui - node (v14.15.1, x64)
  • xstate - node (v10.16.3, x64)
  • xstate - node (v12.1.0, x64)
  • xstate - node (v14.15.1, x64)
Benchmark Name Iterations
Current 50976 10
Baseline main 10

TSServer

Comparison Report - main..50976
Metric main 50976 Delta Best Worst
Compiler-UnionsTSServer - node (v10.16.3, x64)
Req 1 - updateOpen 1,398ms (± 0.32%) 1,407ms (± 0.57%) +9ms (+ 0.65%) 1,387ms 1,426ms
Req 2 - geterr 4,084ms (± 0.66%) 4,124ms (± 0.85%) +40ms (+ 0.97%) 4,050ms 4,205ms
Req 3 - references 229ms (± 0.63%) 230ms (± 0.65%) +1ms (+ 0.57%) 226ms 233ms
Req 4 - navto 171ms (± 1.02%) 172ms (± 1.45%) +1ms (+ 0.53%) 167ms 177ms
Req 5 - completionInfo count 1,356 (± 0.00%) 1,356 (± 0.00%) 0 ( 0.00%) 1,356 1,356
Req 5 - completionInfo 89ms (± 6.20%) 95ms (± 3.11%) +6ms (+ 6.97%) 89ms 100ms
CompilerTSServer - node (v10.16.3, x64)
Req 1 - updateOpen 1,498ms (± 0.49%) 1,498ms (± 0.45%) +1ms (+ 0.04%) 1,479ms 1,514ms
Req 2 - geterr 2,261ms (± 0.31%) 2,261ms (± 0.57%) +1ms (+ 0.04%) 2,230ms 2,286ms
Req 3 - references 244ms (± 0.63%) 243ms (± 0.65%) -1ms (- 0.21%) 241ms 248ms
Req 4 - navto 183ms (± 1.01%) 184ms (± 1.01%) +1ms (+ 0.55%) 180ms 188ms
Req 5 - completionInfo count 1,518 (± 0.00%) 1,518 (± 0.00%) 0 ( 0.00%) 1,518 1,518
Req 5 - completionInfo 60ms (± 1.48%) 62ms (± 2.87%) +1ms (+ 1.82%) 60ms 68ms
xstateTSServer - node (v10.16.3, x64)
Req 1 - updateOpen 2,078ms (± 0.40%) 2,095ms (± 0.53%) +17ms (+ 0.81%) 2,071ms 2,117ms
Req 2 - geterr 805ms (± 0.46%) 799ms (± 0.74%) -5ms (- 0.66%) 787ms 814ms
Req 3 - references 100ms (± 1.37%) 100ms (± 0.81%) 0ms ( 0.00%) 99ms 102ms
Req 4 - navto 233ms (± 1.53%) 233ms (± 1.31%) +1ms (+ 0.21%) 228ms 241ms
Req 5 - completionInfo count 3,205 (± 0.00%) 3,205 (± 0.00%) 0 ( 0.00%) 3,205 3,205
Req 5 - completionInfo 275ms (± 1.03%) 278ms (± 1.32%) +3ms (+ 0.98%) 270ms 285ms
Compiler-UnionsTSServer - node (v12.1.0, x64)
Req 1 - updateOpen 1,409ms (± 0.45%) 1,413ms (± 0.81%) +4ms (+ 0.31%) 1,388ms 1,443ms
Req 2 - geterr 3,401ms (± 0.39%) 3,398ms (± 0.70%) -3ms (- 0.09%) 3,359ms 3,463ms
Req 3 - references 220ms (± 0.78%) 220ms (± 0.72%) -0ms (- 0.14%) 216ms 223ms
Req 4 - navto 162ms (± 1.13%) 161ms (± 1.07%) -1ms (- 0.31%) 157ms 164ms
Req 5 - completionInfo count 1,356 (± 0.00%) 1,356 (± 0.00%) 0 ( 0.00%) 1,356 1,356
Req 5 - completionInfo 60ms (± 5.35%) 60ms (± 4.61%) +1ms (+ 1.34%) 56ms 67ms
CompilerTSServer - node (v12.1.0, x64)
Req 1 - updateOpen 1,505ms (± 0.42%) 1,506ms (± 0.77%) +1ms (+ 0.07%) 1,479ms 1,529ms
Req 2 - geterr 2,182ms (± 0.64%) 2,176ms (± 0.60%) -6ms (- 0.27%) 2,150ms 2,198ms
Req 3 - references 235ms (± 0.92%) 234ms (± 0.74%) -1ms (- 0.55%) 230ms 238ms
Req 4 - navto 172ms (± 1.13%) 171ms (± 0.93%) -1ms (- 0.35%) 167ms 175ms
Req 5 - completionInfo count 1,518 (± 0.00%) 1,518 (± 0.00%) 0 ( 0.00%) 1,518 1,518
Req 5 - completionInfo 60ms (± 3.35%) 60ms (± 2.96%) 0ms ( 0.00%) 57ms 64ms
xstateTSServer - node (v12.1.0, x64)
Req 1 - updateOpen 2,024ms (± 0.40%) 2,044ms (± 0.53%) +20ms (+ 0.97%) 2,013ms 2,070ms
Req 2 - geterr 746ms (± 0.15%) 749ms (± 0.57%) +3ms (+ 0.40%) 740ms 759ms
Req 3 - references 68ms (± 1.09%) 68ms (± 1.79%) -0ms (- 0.59%) 65ms 70ms
Req 4 - navto 223ms (± 1.20%) 224ms (± 1.43%) +1ms (+ 0.45%) 215ms 227ms
Req 5 - completionInfo count 3,205 (± 0.00%) 3,205 (± 0.00%) 0 ( 0.00%) 3,205 3,205
Req 5 - completionInfo 270ms (± 1.13%) 271ms (± 1.07%) +1ms (+ 0.48%) 267ms 279ms
Compiler-UnionsTSServer - node (v14.15.1, x64)
Req 1 - updateOpen 1,448ms (± 0.41%) 1,459ms (± 0.49%) +11ms (+ 0.74%) 1,442ms 1,475ms
Req 2 - geterr 3,524ms (± 0.64%) 3,523ms (± 0.63%) -1ms (- 0.03%) 3,474ms 3,555ms
Req 3 - references 230ms (± 1.07%) 232ms (± 0.43%) +2ms (+ 0.78%) 229ms 234ms
Req 4 - navto 170ms (± 0.74%) 171ms (± 0.82%) +1ms (+ 0.77%) 168ms 174ms
Req 5 - completionInfo count 1,356 (± 0.00%) 1,356 (± 0.00%) 0 ( 0.00%) 1,356 1,356
Req 5 - completionInfo 58ms (± 5.83%) 57ms (± 4.90%) -1ms (- 1.56%) 54ms 67ms
CompilerTSServer - node (v14.15.1, x64)
Req 1 - updateOpen 1,523ms (± 0.56%) 1,529ms (± 0.56%) +6ms (+ 0.40%) 1,513ms 1,545ms
Req 2 - geterr 2,312ms (± 0.38%) 2,329ms (± 0.51%) +18ms (+ 0.76%) 2,304ms 2,355ms
Req 3 - references 242ms (± 0.89%) 242ms (± 0.60%) +0ms (+ 0.04%) 240ms 245ms
Req 4 - navto 178ms (± 0.57%) 179ms (± 0.56%) +1ms (+ 0.28%) 177ms 181ms
Req 5 - completionInfo count 1,518 (± 0.00%) 1,518 (± 0.00%) 0 ( 0.00%) 1,518 1,518
Req 5 - completionInfo 55ms (± 0.67%) 55ms (± 1.22%) +0ms (+ 0.18%) 53ms 56ms
xstateTSServer - node (v14.15.1, x64)
Req 1 - updateOpen 2,137ms (± 0.62%) 2,148ms (± 0.43%) +11ms (+ 0.53%) 2,133ms 2,173ms
Req 2 - geterr 767ms (± 0.46%) 772ms (± 0.48%) +5ms (+ 0.63%) 765ms 781ms
Req 3 - references 67ms (± 1.78%) 67ms (± 1.95%) -0ms (- 0.30%) 65ms 70ms
Req 4 - navto 226ms (± 0.76%) 229ms (± 0.89%) +2ms (+ 0.97%) 223ms 233ms
Req 5 - completionInfo count 3,205 (± 0.00%) 3,205 (± 0.00%) 0 ( 0.00%) 3,205 3,205
Req 5 - completionInfo 273ms (± 1.70%) 272ms (± 1.18%) -1ms (- 0.51%) 268ms 280ms
System
Machine Namets-ci-ubuntu
Platformlinux 4.4.0-210-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v10.16.3, x64)
  • node (v12.1.0, x64)
  • node (v14.15.1, x64)
Scenarios
  • Compiler-UnionsTSServer - node (v10.16.3, x64)
  • Compiler-UnionsTSServer - node (v12.1.0, x64)
  • Compiler-UnionsTSServer - node (v14.15.1, x64)
  • CompilerTSServer - node (v10.16.3, x64)
  • CompilerTSServer - node (v12.1.0, x64)
  • CompilerTSServer - node (v14.15.1, x64)
  • xstateTSServer - node (v10.16.3, x64)
  • xstateTSServer - node (v12.1.0, x64)
  • xstateTSServer - node (v14.15.1, x64)
Benchmark Name Iterations
Current 50976 10
Baseline main 10
Developer Information:

Download Benchmark

typescript-bot avatar Sep 27 '22 22:09 typescript-bot

@typescript-bot test tsserver @typescript-bot test tesserver top100

DanielRosenwasser avatar Sep 27 '22 22:09 DanielRosenwasser

@DanielRosenwasser Here are the results of running the user test suite comparing main and refs/pull/50976/merge:

Everything looks good!

typescript-bot avatar Sep 27 '22 23:09 typescript-bot

@DanielRosenwasser Here are the results of running the top-repos suite comparing main and refs/pull/50976/merge:

Everything looks good!

typescript-bot avatar Sep 28 '22 00:09 typescript-bot

I wonder if this changes existing inference results - are there cases where, under noImplicitAny, the following will now error?

let foo = function foo(paramA = {}) {
};

DanielRosenwasser avatar Sep 28 '22 00:09 DanielRosenwasser

@typescript-bot pack this

DanielRosenwasser avatar Sep 29 '22 19:09 DanielRosenwasser

Heya @DanielRosenwasser, I've started to run the tarball bundle task on this PR at 1843e654ea879a9ca3b48e2930d583fa9bb75f2f. You can monitor the build here.

typescript-bot avatar Sep 29 '22 19:09 typescript-bot

Hey @DanielRosenwasser, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/135550/artifacts?artifactName=tgz&fileId=8B9CF156895EF37778D121867A865C6A63249EC45A1B3211708417BC678B336802&fileName=/typescript-4.9.0-insiders.20220929.tgz"
    }
}

and then running npm install.

typescript-bot avatar Sep 29 '22 20:09 typescript-bot

Weird that the playground build didn't work.

DanielRosenwasser avatar Oct 03 '22 23:10 DanielRosenwasser

I guess as long as getContextualType does "some of the same work" you shouldn't see any divergences.

DanielRosenwasser avatar Oct 03 '22 23:10 DanielRosenwasser

I'd feel better if we merged this early in the 5.0 release cycle.

DanielRosenwasser avatar Oct 28 '22 22:10 DanielRosenwasser