TypeScript fix(50551): Destructuring assignment with var bypasses "variable is used before being assigned" check (2454)

Fixes #50551

Aug 31 '22 07:08 a-tarasyuk

@typescript-bot test this @typescript-bot user test this @typescript-bot perf test this @typescript-bot test top100

Aug 31 '22 07:08 DanielRosenwasser

Heya @DanielRosenwasser, I've started to run the diff-based user code test suite on this PR at f279dd5edccc6c93b8f6996e7c71da5a37f440e9. You can monitor the build here.

Aug 31 '22 07:08 typescript-bot

Heya @DanielRosenwasser, I've started to run the diff-based user code test suite on this PR at f279dd5edccc6c93b8f6996e7c71da5a37f440e9. You can monitor the build here.

Update: The results are in!

Aug 31 '22 07:08 typescript-bot

Heya @DanielRosenwasser, I've started to run the perf test suite on this PR at f279dd5edccc6c93b8f6996e7c71da5a37f440e9. You can monitor the build here.

Update: The results are in!

Aug 31 '22 07:08 typescript-bot

Heya @DanielRosenwasser, I've started to run the extended test suite on this PR at f279dd5edccc6c93b8f6996e7c71da5a37f440e9. You can monitor the build here.

Aug 31 '22 07:08 typescript-bot

@DanielRosenwasser Here are the results of running the user test suite comparing main and refs/pull/50560/merge:

Something interesting changed - please have a look.

Details

puppeteer

scripts/tsconfig.json

[NEW] error TS2454: Variable 'devtools' is used before being assigned.
- src/node/ChromeLauncher.ts#L225
- src/node/FirefoxLauncher.ts#L215

tsconfig.json

[NEW] error TS2454: Variable 'devtools' is used before being assigned.
- src/node/ChromeLauncher.ts#L225
- src/node/FirefoxLauncher.ts#L215

Aug 31 '22 07:08 typescript-bot

Heya @DanielRosenwasser, I've run the RWC suite on this PR - assuming you're on the TS core team, you can view the resulting diff here.

Aug 31 '22 08:08 typescript-bot

Looks like this breaks valid code and needs some other checks as well. Why this was condition was accounted for, but not tested, is surprising. So we need a test like

declare const obj: { a?: string, b?: number };
const {
  a = "0",
  b = +a,
} = obj;

This should not trigger an error.

Aug 31 '22 08:08 DanielRosenwasser

@DanielRosenwasser The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - main..50560

_Metric	_main	₅₀₅₆₀	_Delta	_Best	_Worst
_{Angular - node (v10.16.3, x64)}
_{Memory used}	_{363,148k (± 0.02%)}	_{363,154k (± 0.02%)}	_{+7k (+ 0.00%)}	_362,936k	_363,328k
_{Parse Time}	_{2.10s (± 0.64%)}	_{2.09s (± 0.83%)}	_{-0.01s (- 0.62%)}	_2.06s	_2.13s
_{Bind Time}	_{0.79s (± 0.84%)}	_{0.79s (± 0.57%)}	_{-0.00s (- 0.25%)}	_0.78s	_0.80s
_{Check Time}	_{6.18s (± 0.69%)}	_{6.13s (± 0.52%)}	_{-0.05s (- 0.74%)}	_6.06s	_6.20s
_{Emit Time}	_{6.07s (± 0.87%)}	_{5.96s (± 0.75%)}	_{-0.10s (- 1.70%)}	_5.87s	_6.09s
_{Total Time}	_{15.13s (± 0.53%)}	_{14.97s (± 0.56%)}	_{-0.16s (- 1.07%)}	_14.82s	_15.19s
_{Compiler-Unions - node (v10.16.3, x64)}
_{Memory used}	_{206,058k (± 0.04%)}	_{206,115k (± 0.05%)}	_{+57k (+ 0.03%)}	_205,898k	_206,394k
_{Parse Time}	_{0.84s (± 1.01%)}	_{0.84s (± 0.71%)}	_{-0.00s (- 0.36%)}	_0.82s	_0.85s
_{Bind Time}	_{0.47s (± 1.04%)}	_{0.47s (± 0.85%)}	_{-0.00s (- 0.63%)}	_0.46s	_0.48s
_{Check Time}	_{8.47s (± 0.21%)}	_{8.38s (± 0.63%)}	_{-0.09s (- 1.06%)}	_8.27s	_8.53s
_{Emit Time}	_{2.50s (± 1.53%)}	_{2.48s (± 0.77%)}	_{-0.02s (- 0.76%)}	_2.44s	_2.54s
_{Total Time}	_{12.29s (± 0.29%)}	_{12.17s (± 0.44%)}	_{-0.12s (- 0.97%)}	_12.05s	_12.32s
_{Monaco - node (v10.16.3, x64)}
_{Memory used}	_{344,739k (± 0.03%)}	_{344,651k (± 0.02%)}	_{-88k (- 0.03%)}	_344,397k	_344,847k
_{Parse Time}	_{1.61s (± 0.74%)}	_{1.60s (± 0.69%)}	_{-0.01s (- 0.31%)}	_1.58s	_1.63s
_{Bind Time}	_{0.70s (± 0.63%)}	_{0.69s (± 0.86%)}	_{-0.01s (- 1.00%)}	_0.68s	_0.71s
_{Check Time}	_{6.26s (± 0.39%)}	_{6.21s (± 0.48%)}	_{-0.05s (- 0.77%)}	_6.13s	_6.28s
_{Emit Time}	_{3.23s (± 0.99%)}	_{3.21s (± 1.03%)}	_{-0.03s (- 0.80%)}	_3.15s	_3.29s
_{Total Time}	_{11.81s (± 0.43%)}	_{11.72s (± 0.47%)}	_{-0.09s (- 0.73%)}	_11.61s	_11.86s
_{TFS - node (v10.16.3, x64)}
_{Memory used}	_{305,921k (± 0.01%)}	_{305,845k (± 0.02%)}	_{-76k (- 0.02%)}	_305,671k	_305,955k
_{Parse Time}	_{1.29s (± 0.70%)}	_{1.29s (± 0.76%)}	_{+0.00s (+ 0.23%)}	_1.26s	_1.31s
_{Bind Time}	_{0.68s (± 0.77%)}	_{0.67s (± 1.01%)}	_{-0.01s (- 0.74%)}	_0.66s	_0.69s
_{Check Time}	_{5.51s (± 0.68%)}	_{5.51s (± 0.36%)}	_{-0.01s (- 0.09%)}	_5.45s	_5.56s
_{Emit Time}	_{3.42s (± 2.11%)}	_{3.42s (± 1.51%)}	_{+0.01s (+ 0.18%)}	_3.30s	_3.57s
_{Total Time}	_{10.90s (± 0.83%)}	_{10.89s (± 0.57%)}	_{-0.00s (- 0.03%)}	_10.76s	_11.10s
_{material-ui - node (v10.16.3, x64)}
_{Memory used}	_{460,722k (± 0.01%)}	_{460,773k (± 0.01%)}	_{+51k (+ 0.01%)}	_460,683k	_460,903k
_{Parse Time}	_{1.83s (± 0.82%)}	_{1.82s (± 0.73%)}	_{-0.01s (- 0.49%)}	_1.80s	_1.86s
_{Bind Time}	_{0.58s (± 1.79%)}	_{0.59s (± 1.29%)}	_{+0.00s (+ 0.69%)}	_0.57s	_0.60s
_{Check Time}	_{15.81s (± 0.76%)}	_{15.76s (± 0.74%)}	_{-0.05s (- 0.34%)}	_15.53s	_16.01s
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_{0.00s ( NaN%)}	_0.00s	_0.00s
_{Total Time}	_{18.23s (± 0.73%)}	_{18.17s (± 0.67%)}	_{-0.06s (- 0.33%)}	_17.93s	_18.43s
_{xstate - node (v10.16.3, x64)}
_{Memory used}	_{587,723k (± 1.25%)}	_{584,437k (± 0.02%)}	_{-3,287k (- 0.56%)}	_584,178k	_584,595k
_{Parse Time}	_{2.62s (± 0.47%)}	_{2.62s (± 0.46%)}	_{-0.01s (- 0.23%)}	_2.59s	_2.65s
_{Bind Time}	_{0.92s (± 0.67%)}	_{0.92s (± 0.65%)}	_{-0.01s (- 0.54%)}	_0.91s	_0.93s
_{Check Time}	_{1.63s (± 0.47%)}	_{1.63s (± 0.79%)}	_{+0.00s (+ 0.06%)}	_1.60s	_1.66s
_{Emit Time}	_{0.07s (± 4.13%)}	_{0.07s (± 4.13%)}	_{0.00s ( 0.00%)}	_0.07s	_0.08s
_{Total Time}	_{5.24s (± 0.27%)}	_{5.23s (± 0.44%)}	_{-0.01s (- 0.25%)}	_5.18s	_5.29s
_{Angular - node (v12.1.0, x64)}
_{Memory used}	_{340,592k (± 0.09%)}	_{340,702k (± 0.03%)}	_{+111k (+ 0.03%)}	_340,440k	_340,857k
_{Parse Time}	_{2.08s (± 0.57%)}	_{2.07s (± 0.49%)}	_{-0.01s (- 0.34%)}	_2.04s	_2.09s
_{Bind Time}	_{0.77s (± 0.58%)}	_{0.77s (± 0.68%)}	_{+0.00s (+ 0.13%)}	_0.76s	_0.78s
_{Check Time}	_{5.83s (± 0.64%)}	_{5.82s (± 0.83%)}	_{-0.01s (- 0.21%)}	_5.76s	_6.00s
_{Emit Time}	_{6.25s (± 0.80%)}	_{6.20s (± 0.41%)}	_{-0.05s (- 0.74%)}	_6.16s	_6.26s
_{Total Time}	_{14.93s (± 0.47%)}	_{14.86s (± 0.40%)}	_{-0.07s (- 0.44%)}	_14.77s	_15.03s
_{Compiler-Unions - node (v12.1.0, x64)}
_{Memory used}	_{193,897k (± 0.12%)}	_{193,946k (± 0.11%)}	_{+49k (+ 0.03%)}	_193,127k	_194,170k
_{Parse Time}	_{0.83s (± 0.99%)}	_{0.82s (± 0.92%)}	_{-0.01s (- 1.20%)}	_0.81s	_0.84s
_{Bind Time}	_{0.47s (± 1.25%)}	_{0.47s (± 0.94%)}	_{-0.00s (- 0.42%)}	_0.46s	_0.48s
_{Check Time}	_{6.68s (± 0.40%)}	_{6.64s (± 0.50%)}	_{-0.04s (- 0.67%)}	_6.55s	_6.70s
_{Emit Time}	_{2.47s (± 1.87%)}	_{2.45s (± 0.88%)}	_{-0.02s (- 0.89%)}	_2.41s	_2.49s
_{Total Time}	_{10.46s (± 0.56%)}	_{10.39s (± 0.46%)}	_{-0.08s (- 0.73%)}	_10.25s	_10.47s
_{Monaco - node (v12.1.0, x64)}
_{Memory used}	_{327,692k (± 0.01%)}	_{327,700k (± 0.02%)}	_{+8k (+ 0.00%)}	_327,472k	_327,867k
_{Parse Time}	_{1.58s (± 0.97%)}	_{1.57s (± 0.72%)}	_{-0.01s (- 0.63%)}	_1.54s	_1.60s
_{Bind Time}	_{0.70s (± 0.93%)}	_{0.70s (± 1.00%)}	_{+0.00s (+ 0.14%)}	_0.69s	_0.72s
_{Check Time}	_{5.85s (± 0.47%)}	_{5.77s (± 0.36%)}	_{-0.08s (- 1.30%)}	_5.74s	_5.81s
_{Emit Time}	_{3.30s (± 0.74%)}	_{3.30s (± 1.34%)}	_{+0.00s (+ 0.15%)}	_3.22s	_3.45s
_{Total Time}	_{11.43s (± 0.45%)}	_{11.35s (± 0.38%)}	_{-0.08s (- 0.70%)}	_11.24s	_11.46s
_{TFS - node (v12.1.0, x64)}
_{Memory used}	_{290,427k (± 0.08%)}	_{290,448k (± 0.06%)}	_{+21k (+ 0.01%)}	_289,786k	_290,650k
_{Parse Time}	_{1.30s (± 1.03%)}	_{1.29s (± 0.72%)}	_{-0.01s (- 0.69%)}	_1.27s	_1.31s
_{Bind Time}	_{0.68s (± 1.18%)}	_{0.67s (± 1.16%)}	_{-0.01s (- 1.33%)}	_0.65s	_0.69s
_{Check Time}	_{5.40s (± 0.57%)}	_{5.37s (± 0.69%)}	_{-0.03s (- 0.54%)}	_5.30s	_5.45s
_{Emit Time}	_{3.51s (± 0.87%)}	_{3.46s (± 0.77%)}	_{-0.05s (- 1.37%)}	_3.41s	_3.51s
_{Total Time}	_{10.88s (± 0.53%)}	_{10.78s (± 0.29%)}	_{-0.09s (- 0.87%)}	_10.72s	_10.85s
_{material-ui - node (v12.1.0, x64)}
_{Memory used}	_{439,760k (± 0.09%)}	_{439,951k (± 0.07%)}	_{+191k (+ 0.04%)}	_438,798k	_440,246k
_{Parse Time}	_{1.82s (± 0.92%)}	_{1.81s (± 0.48%)}	_{-0.01s (- 0.49%)}	_1.80s	_1.83s
_{Bind Time}	_{0.56s (± 1.07%)}	_{0.55s (± 0.60%)}	_{-0.01s (- 1.08%)}	_0.54s	_0.56s
_{Check Time}	_{12.90s (± 1.45%)}	_{12.75s (± 0.56%)}	_{-0.15s (- 1.12%)}	_12.64s	_12.94s
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_{0.00s ( NaN%)}	_0.00s	_0.00s
_{Total Time}	_{15.27s (± 1.32%)}	_{15.12s (± 0.48%)}	_{-0.16s (- 1.02%)}	_14.99s	_15.30s
_{xstate - node (v12.1.0, x64)}
_{Memory used}	_{552,857k (± 1.28%)}	_{549,704k (± 0.01%)}	_{-3,153k (- 0.57%)}	_549,501k	_549,835k
_{Parse Time}	_{2.55s (± 0.65%)}	_{2.54s (± 0.54%)}	_{-0.01s (- 0.47%)}	_2.51s	_2.58s
_{Bind Time}	_{0.89s (± 0.65%)}	_{0.89s (± 0.75%)}	_{0.00s ( 0.00%)}	_0.88s	_0.90s
_{Check Time}	_{1.49s (± 0.57%)}	_{1.49s (± 0.45%)}	_{+0.00s (+ 0.13%)}	_1.48s	_1.51s
_{Emit Time}	_{0.07s (± 0.00%)}	_{0.07s (± 0.00%)}	_{0.00s ( 0.00%)}	_0.07s	_0.07s
_{Total Time}	_{5.00s (± 0.48%)}	_{4.99s (± 0.43%)}	_{-0.02s (- 0.34%)}	_4.95s	_5.05s
_{Angular - node (v14.15.1, x64)}
_{Memory used}	_{338,732k (± 0.00%)}	_{338,717k (± 0.00%)}	_{-15k (- 0.00%)}	_338,674k	_338,759k
_{Parse Time}	_{2.08s (± 1.37%)}	_{2.08s (± 0.91%)}	_{-0.01s (- 0.29%)}	_2.05s	_2.13s
_{Bind Time}	_{0.79s (± 0.38%)}	_{0.79s (± 0.62%)}	_{+0.00s (+ 0.25%)}	_0.79s	_0.81s
_{Check Time}	_{5.82s (± 0.45%)}	_{5.83s (± 0.51%)}	_{+0.01s (+ 0.10%)}	_5.77s	_5.90s
_{Emit Time}	_{6.14s (± 0.63%)}	_{6.11s (± 0.46%)}	_{-0.03s (- 0.54%)}	_6.07s	_6.19s
_{Total Time}	_{14.84s (± 0.46%)}	_{14.81s (± 0.32%)}	_{-0.03s (- 0.22%)}	_14.73s	_14.91s
_{Compiler-Unions - node (v14.15.1, x64)}
_{Memory used}	_{192,635k (± 0.01%)}	_{192,546k (± 0.12%)}	_{-89k (- 0.05%)}	_191,606k	_192,692k
_{Parse Time}	_{0.86s (± 0.78%)}	_{0.85s (± 0.94%)}	_{-0.01s (- 0.58%)}	_0.84s	_0.87s
_{Bind Time}	_{0.49s (± 0.91%)}	_{0.48s (± 0.75%)}	_{-0.00s (- 0.82%)}	_0.48s	_0.49s
_{Check Time}	_{6.69s (± 0.41%)}	_{6.67s (± 0.95%)}	_{-0.02s (- 0.27%)}	_6.54s	_6.87s
_{Emit Time}	_{2.39s (± 0.46%)}	_{2.42s (± 1.03%)}	_{+0.03s (+ 1.17%)}	_2.38s	_2.49s
_{Total Time}	_{10.43s (± 0.28%)}	_{10.43s (± 0.68%)}	_{+0.00s (+ 0.02%)}	_10.25s	_10.64s
_{Monaco - node (v14.15.1, x64)}
_{Memory used}	_{326,520k (± 0.01%)}	_{326,527k (± 0.01%)}	_{+8k (+ 0.00%)}	_326,477k	_326,569k
_{Parse Time}	_{1.58s (± 0.64%)}	_{1.58s (± 0.89%)}	_{+0.00s (+ 0.19%)}	_1.55s	_1.61s
_{Bind Time}	_{0.72s (± 0.77%)}	_{0.73s (± 0.96%)}	_{+0.01s (+ 1.25%)}	_0.72s	_0.75s
_{Check Time}	_{5.72s (± 0.28%)}	_{5.71s (± 0.61%)}	_{-0.01s (- 0.23%)}	_5.61s	_5.76s
_{Emit Time}	_{3.32s (± 0.72%)}	_{3.31s (± 0.82%)}	_{-0.00s (- 0.09%)}	_3.25s	_3.37s
_{Total Time}	_{11.33s (± 0.25%)}	_{11.33s (± 0.47%)}	_{-0.01s (- 0.05%)}	_11.21s	_11.43s
_{TFS - node (v14.15.1, x64)}
_{Memory used}	_{289,622k (± 0.01%)}	_{289,643k (± 0.01%)}	_{+21k (+ 0.01%)}	_289,601k	_289,688k
_{Parse Time}	_{1.30s (± 0.73%)}	_{1.31s (± 0.63%)}	_{+0.00s (+ 0.23%)}	_1.28s	_1.32s
_{Bind Time}	_{0.79s (± 0.78%)}	_{0.79s (± 0.75%)}	_{+0.00s (+ 0.38%)}	_0.78s	_0.81s
_{Check Time}	_{5.34s (± 0.39%)}	_{5.32s (± 0.22%)}	_{-0.02s (- 0.34%)}	_5.30s	_5.35s
_{Emit Time}	_{3.60s (± 0.64%)}	_{3.57s (± 0.72%)}	_{-0.03s (- 0.78%)}	_3.53s	_3.64s
_{Total Time}	_{11.03s (± 0.37%)}	_{10.99s (± 0.26%)}	_{-0.04s (- 0.37%)}	_10.95s	_11.06s
_{material-ui - node (v14.15.1, x64)}
_{Memory used}	_{438,198k (± 0.00%)}	_{438,070k (± 0.06%)}	_{-128k (- 0.03%)}	_437,036k	_438,232k
_{Parse Time}	_{1.86s (± 0.40%)}	_{1.86s (± 0.54%)}	_{-0.00s (- 0.05%)}	_1.83s	_1.88s
_{Bind Time}	_{0.58s (± 0.82%)}	_{0.58s (± 0.99%)}	_{-0.00s (- 0.51%)}	_0.57s	_0.60s
_{Check Time}	_{12.90s (± 0.52%)}	_{12.87s (± 0.64%)}	_{-0.03s (- 0.22%)}	_12.75s	_13.13s
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_{0.00s ( NaN%)}	_0.00s	_0.00s
_{Total Time}	_{15.34s (± 0.43%)}	_{15.31s (± 0.49%)}	_{-0.03s (- 0.22%)}	_15.18s	_15.53s
_{xstate - node (v14.15.1, x64)}
_{Memory used}	_{547,392k (± 0.00%)}	_{547,409k (± 0.00%)}	_{+17k (+ 0.00%)}	_547,348k	_547,441k
_{Parse Time}	_{2.60s (± 0.32%)}	_{2.59s (± 0.37%)}	_{-0.00s (- 0.19%)}	_2.57s	_2.62s
_{Bind Time}	_{0.97s (± 0.77%)}	_{0.97s (± 0.46%)}	_{-0.01s (- 0.51%)}	_0.96s	_0.98s
_{Check Time}	_{1.54s (± 0.54%)}	_{1.54s (± 0.36%)}	_{+0.01s (+ 0.39%)}	_1.53s	_1.55s
_{Emit Time}	_{0.07s (± 3.14%)}	_{0.07s (± 4.13%)}	_{+0.00s (+ 1.41%)}	_0.07s	_0.08s
_{Total Time}	_{5.19s (± 0.30%)}	_{5.17s (± 0.22%)}	_{-0.01s (- 0.19%)}	_5.14s	_5.19s

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 4.4.0-210-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{15 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v10.16.3, x64)
node (v12.1.0, x64)
node (v14.15.1, x64)

Scenarios

Angular - node (v10.16.3, x64)
Angular - node (v12.1.0, x64)
Angular - node (v14.15.1, x64)
Compiler-Unions - node (v10.16.3, x64)
Compiler-Unions - node (v12.1.0, x64)
Compiler-Unions - node (v14.15.1, x64)
Monaco - node (v10.16.3, x64)
Monaco - node (v12.1.0, x64)
Monaco - node (v14.15.1, x64)
TFS - node (v10.16.3, x64)
TFS - node (v12.1.0, x64)
TFS - node (v14.15.1, x64)
material-ui - node (v10.16.3, x64)
material-ui - node (v12.1.0, x64)
material-ui - node (v14.15.1, x64)
xstate - node (v10.16.3, x64)
xstate - node (v12.1.0, x64)
xstate - node (v14.15.1, x64)

_Benchmark	_Name	_Iterations
_Current	₅₀₅₆₀	₁₀
_Baseline	_main	₁₀

TSServer

Comparison Report - main..50560

_Metric	_main	₅₀₅₆₀	_Delta	_Best	_Worst
_{Compiler-UnionsTSServer - node (v10.16.3, x64)}
_{Req 1 - updateOpen}	_{1,408ms (± 0.38%)}	_{1,399ms (± 0.45%)}	_{-9ms (- 0.64%)}	_1,389ms	_1,417ms
_{Req 2 - geterr}	_{4,116ms (± 0.43%)}	_{4,111ms (± 0.78%)}	_{-5ms (- 0.11%)}	_4,021ms	_4,166ms
_{Req 3 - references}	_{231ms (± 0.77%)}	_{231ms (± 0.79%)}	_{-0ms (- 0.13%)}	_226ms	_235ms
_{Req 4 - navto}	_{172ms (± 1.12%)}	_{172ms (± 0.41%)}	_{-0ms (- 0.12%)}	_170ms	_174ms
_{Req 5 - completionInfo count}	_{1,356 (± 0.00%)}	_{1,356 (± 0.00%)}	_{0 ( 0.00%)}	_1,356	_1,356
_{Req 5 - completionInfo}	_{92ms (± 6.61%)}	_{91ms (± 7.97%)}	_{-1ms (- 1.08%)}	_64ms	_99ms
_{CompilerTSServer - node (v10.16.3, x64)}
_{Req 1 - updateOpen}	_{1,502ms (± 0.49%)}	_{1,499ms (± 0.60%)}	_{-3ms (- 0.21%)}	_1,480ms	_1,528ms
_{Req 2 - geterr}	_{2,255ms (± 0.49%)}	_{2,250ms (± 0.57%)}	_{-5ms (- 0.24%)}	_2,225ms	_2,292ms
_{Req 3 - references}	_{242ms (± 0.61%)}	_{241ms (± 0.55%)}	_{-1ms (- 0.37%)}	_239ms	_246ms
_{Req 4 - navto}	_{184ms (± 1.12%)}	_{184ms (± 0.81%)}	_{-1ms (- 0.33%)}	_181ms	_187ms
_{Req 5 - completionInfo count}	_{1,518 (± 0.00%)}	_{1,518 (± 0.00%)}	_{0 ( 0.00%)}	_1,518	_1,518
_{Req 5 - completionInfo}	_{69ms (± 0.84%)}	_{69ms (± 1.31%)}	_{+0ms (+ 0.58%)}	_67ms	_71ms
_{xstateTSServer - node (v10.16.3, x64)}
_{Req 1 - updateOpen}	_{2,095ms (± 0.40%)}	_{2,082ms (± 0.47%)}	_{-13ms (- 0.63%)}	_2,061ms	_2,102ms
_{Req 2 - geterr}	_{804ms (± 0.67%)}	_{799ms (± 0.77%)}	_{-5ms (- 0.58%)}	_790ms	_816ms
_{Req 3 - references}	_{100ms (± 1.96%)}	_{98ms (± 1.48%)}	_{-2ms (- 1.99%)}	_96ms	_102ms
_{Req 4 - navto}	_{232ms (± 0.74%)}	_{233ms (± 0.84%)}	_{+1ms (+ 0.22%)}	_228ms	_238ms
_{Req 5 - completionInfo count}	_{3,301 (± 0.00%)}	_{3,301 (± 0.00%)}	_{0 ( 0.00%)}	_3,301	_3,301
_{Req 5 - completionInfo}	_{283ms (± 0.65%)}	_{279ms (± 1.21%)}	_{-4ms (- 1.27%)}	_268ms	_284ms
_{Compiler-UnionsTSServer - node (v12.1.0, x64)}
_{Req 1 - updateOpen}	_{1,404ms (± 0.69%)}	_{1,403ms (± 0.57%)}	_{-1ms (- 0.09%)}	_1,386ms	_1,420ms
_{Req 2 - geterr}	_{3,372ms (± 0.38%)}	_{3,351ms (± 0.29%)}	_{-21ms (- 0.61%)}	_3,328ms	_3,378ms
_{Req 3 - references}	_{219ms (± 0.91%)}	_{220ms (± 0.83%)}	_{+1ms (+ 0.23%)}	_217ms	_226ms
_{Req 4 - navto}	_{161ms (± 1.14%)}	_{161ms (± 1.05%)}	_{+0ms (+ 0.06%)}	_157ms	_164ms
_{Req 5 - completionInfo count}	_{1,356 (± 0.00%)}	_{1,356 (± 0.00%)}	_{0 ( 0.00%)}	_1,356	_1,356
_{Req 5 - completionInfo}	_{60ms (± 5.54%)}	_{61ms (± 4.53%)}	_{+2ms (+ 2.51%)}	_56ms	_68ms
_{CompilerTSServer - node (v12.1.0, x64)}
_{Req 1 - updateOpen}	_{1,493ms (± 0.67%)}	_{1,486ms (± 0.49%)}	_{-7ms (- 0.47%)}	_1,475ms	_1,500ms
_{Req 2 - geterr}	_{2,164ms (± 0.50%)}	_{2,172ms (± 0.35%)}	_{+8ms (+ 0.38%)}	_2,160ms	_2,197ms
_{Req 3 - references}	_{232ms (± 0.80%)}	_{233ms (± 0.63%)}	_{+1ms (+ 0.35%)}	_228ms	_235ms
_{Req 4 - navto}	_{172ms (± 1.30%)}	_{171ms (± 1.28%)}	_{-1ms (- 0.35%)}	_166ms	_176ms
_{Req 5 - completionInfo count}	_{1,518 (± 0.00%)}	_{1,518 (± 0.00%)}	_{0 ( 0.00%)}	_1,518	_1,518
_{Req 5 - completionInfo}	_{63ms (± 3.71%)}	_{64ms (± 3.40%)}	_{+1ms (+ 1.11%)}	_59ms	_67ms
_{xstateTSServer - node (v12.1.0, x64)}
_{Req 1 - updateOpen}	_{2,038ms (± 0.66%)}	_{2,038ms (± 0.44%)}	_{+1ms (+ 0.02%)}	_2,018ms	_2,056ms
_{Req 2 - geterr}	_{751ms (± 0.44%)}	_{754ms (± 0.74%)}	_{+3ms (+ 0.36%)}	_744ms	_773ms
_{Req 3 - references}	_{67ms (± 0.92%)}	_{67ms (± 0.96%)}	_{+0ms (+ 0.45%)}	_66ms	_69ms
_{Req 4 - navto}	_{224ms (± 1.83%)}	_{222ms (± 1.58%)}	_{-1ms (- 0.63%)}	_213ms	_226ms
_{Req 5 - completionInfo count}	_{3,301 (± 0.00%)}	_{3,301 (± 0.00%)}	_{0 ( 0.00%)}	_3,301	_3,301
_{Req 5 - completionInfo}	_{273ms (± 1.21%)}	_{275ms (± 1.00%)}	_{+2ms (+ 0.66%)}	_268ms	_280ms
_{Compiler-UnionsTSServer - node (v14.15.1, x64)}
_{Req 1 - updateOpen}	_{1,441ms (± 0.43%)}	_{1,437ms (± 0.29%)}	_{-5ms (- 0.31%)}	_1,428ms	_1,446ms
_{Req 2 - geterr}	_{3,489ms (± 0.41%)}	_{3,450ms (± 0.48%)}	_{-39ms (- 1.13%)}	_3,416ms	_3,491ms
_{Req 3 - references}	_{229ms (± 0.66%)}	_{228ms (± 0.44%)}	_{-0ms (- 0.17%)}	_226ms	_231ms
_{Req 4 - navto}	_{168ms (± 0.72%)}	_{168ms (± 0.54%)}	_{-1ms (- 0.30%)}	_166ms	_170ms
_{Req 5 - completionInfo count}	_{1,356 (± 0.00%)}	_{1,356 (± 0.00%)}	_{0 ( 0.00%)}	_1,356	_1,356
_{Req 5 - completionInfo}	_{56ms (± 1.23%)}	_{56ms (± 1.04%)}	_{+0ms (+ 0.36%)}	_55ms	_57ms
_{CompilerTSServer - node (v14.15.1, x64)}
_{Req 1 - updateOpen}	_{1,521ms (± 0.68%)}	_{1,523ms (± 0.61%)}	_{+2ms (+ 0.15%)}	_1,505ms	_1,545ms
_{Req 2 - geterr}	_{2,299ms (± 0.50%)}	_{2,292ms (± 0.28%)}	_{-7ms (- 0.30%)}	_2,277ms	_2,310ms
_{Req 3 - references}	_{242ms (± 0.59%)}	_{243ms (± 0.63%)}	_{+1ms (+ 0.33%)}	_239ms	_245ms
_{Req 4 - navto}	_{178ms (± 0.49%)}	_{178ms (± 0.55%)}	_{-0ms (- 0.11%)}	_176ms	_181ms
_{Req 5 - completionInfo count}	_{1,518 (± 0.00%)}	_{1,518 (± 0.00%)}	_{0 ( 0.00%)}	_1,518	_1,518
_{Req 5 - completionInfo}	_{55ms (± 1.06%)}	_{54ms (± 0.63%)}	_{-0ms (- 0.73%)}	_54ms	_55ms
_{xstateTSServer - node (v14.15.1, x64)}
_{Req 1 - updateOpen}	_{2,139ms (± 0.57%)}	_{2,138ms (± 0.52%)}	_{-1ms (- 0.06%)}	_2,112ms	_2,156ms
_{Req 2 - geterr}	_{772ms (± 0.58%)}	_{770ms (± 0.52%)}	_{-2ms (- 0.21%)}	_762ms	_779ms
_{Req 3 - references}	_{67ms (± 2.13%)}	_{67ms (± 1.88%)}	_{0ms ( 0.00%)}	_64ms	_69ms
_{Req 4 - navto}	_{228ms (± 0.53%)}	_{227ms (± 0.65%)}	_{-1ms (- 0.31%)}	_225ms	_232ms
_{Req 5 - completionInfo count}	_{3,301 (± 0.00%)}	_{3,301 (± 0.00%)}	_{0 ( 0.00%)}	_3,301	_3,301
_{Req 5 - completionInfo}	_{276ms (± 0.62%)}	_{277ms (± 0.91%)}	_{+1ms (+ 0.22%)}	_272ms	_282ms

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 4.4.0-210-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{15 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v10.16.3, x64)
node (v12.1.0, x64)
node (v14.15.1, x64)

Scenarios

Compiler-UnionsTSServer - node (v10.16.3, x64)
Compiler-UnionsTSServer - node (v12.1.0, x64)
Compiler-UnionsTSServer - node (v14.15.1, x64)
CompilerTSServer - node (v10.16.3, x64)
CompilerTSServer - node (v12.1.0, x64)
CompilerTSServer - node (v14.15.1, x64)
xstateTSServer - node (v10.16.3, x64)
xstateTSServer - node (v12.1.0, x64)
xstateTSServer - node (v14.15.1, x64)

_Benchmark	_Name	_Iterations
_Current	₅₀₅₆₀	₁₀
_Baseline	_main	₁₀

Developer Information:

Download Benchmark

Aug 31 '22 08:08 typescript-bot

@typescript-bot user test this

Oct 18 '22 22:10 gabritto

Heya @gabritto, I've started to run the diff-based user code test suite on this PR at a6e5486a25f50d501385d6f3a11bacf53de748ba. You can monitor the build here.

Update: The results are in!

Oct 18 '22 22:10 typescript-bot

@gabritto Here are the results of running the user test suite comparing main and refs/pull/50560/merge:

Everything looks good!

Oct 18 '22 22:10 typescript-bot

@typescript-bot test this @typescript-bot user test this @typescript-bot perf test this @typescript-bot test top100

Oct 19 '22 18:10 gabritto

Heya @gabritto, I've started to run the diff-based top-repos suite on this PR at 7074198a697d210bb62a5e3c56c8b0add5589816. You can monitor the build here.

Update: The results are in!