TypeScript-DOM-lib-generator icon indicating copy to clipboard operation
TypeScript-DOM-lib-generator copied to clipboard

Remove some compat quirk

Open petamoriken opened this issue 1 year ago • 2 comments

https://github.com/microsoft/TypeScript-DOM-lib-generator/pull/1713#issuecomment-2248890913

types/web also has some compat quirk that had to mismatch with the spec, e.g. ChildNode being only a mixin interface inherited by some Node variants but types/web had to make it inherit from Node, reversing the inheritance, because back in the day we thought maybe we should put the compat first before correctness.

But if https://github.com/microsoft/TypeScript/pull/58222 didn't break DefinitelyTyped then maybe it's a good chance to remove one quirk.

petamoriken avatar Jul 28 '24 15:07 petamoriken

Thanks for the PR!

This section of the codebase is owned by @saschanaz - if they write a comment saying "LGTM" then it will be merged.

github-actions[bot] avatar Jul 28 '24 15:07 github-actions[bot]

Oh I said the quirk #1713 is removing, not this quirk. I'm much less confident that this would be compatible with the ecosystem. But you can try submitting a draft PR into microsoft/TypeScript with this change and see what it catches.

saschanaz avatar Jul 28 '24 18:07 saschanaz