TypeScript-DOM-lib-generator icon indicating copy to clipboard operation
TypeScript-DOM-lib-generator copied to clipboard
verified publisher icon microsoft

fix: use `RTCErrorEvent` for `RTCDataChannel` `error` event

Open wackbyte opened this issue 1 year ago • 2 comments

Reference: https://www.w3.org/TR/webrtc/#event-summary

Like #1661, this PR is already covered by #1660. I'm opening it despite this since it seems like that PR has no momentum right now.

wackbyte avatar Jun 19 '24 00:06 wackbyte

Thanks for the PR!

This section of the codebase is owned by @saschanaz - if they write a comment saying "LGTM" then it will be merged.

github-actions[bot] avatar Jun 19 '24 00:06 github-actions[bot]

@microsoft-github-policy-service agree

wackbyte avatar Jun 19 '24 00:06 wackbyte

Sorry for the delay, LGTM

saschanaz avatar Aug 22 '24 20:08 saschanaz

There was an issue merging, maybe try again saschanaz. Details

github-actions[bot] avatar Aug 22 '24 20:08 github-actions[bot]

Merge failed 😅

saschanaz avatar Aug 22 '24 20:08 saschanaz

#1660 fixed this, closing.

@github-actions close

saschanaz avatar Oct 03 '24 11:10 saschanaz

Closing because @saschanaz is one of the code-owners of this repository.

github-actions[bot] avatar Oct 03 '24 11:10 github-actions[bot]