TypeScript-DOM-lib-generator icon indicating copy to clipboard operation
TypeScript-DOM-lib-generator copied to clipboard

misc(docs): rectify typos and spelling mistakes

Open adeyinkaezra123 opened this issue 2 years ago • 9 comments

Created a fresh branch to clean up the commit tree

adeyinkaezra123 avatar Oct 08 '23 18:10 adeyinkaezra123

Thanks for the PR!

This section of the codebase is owned by @saschanaz - if they write a comment saying "LGTM" then it will be merged.

github-actions[bot] avatar Oct 08 '23 18:10 github-actions[bot]

You need to rebuild, btw.

saschanaz avatar Oct 08 '23 19:10 saschanaz

You need to rebuild, btw.

How do I do that?

adeyinkaezra123 avatar Oct 08 '23 19:10 adeyinkaezra123

See: https://github.com/microsoft/TypeScript-DOM-lib-generator#build-instructions (npm run build && npm run baseline-accept)

saschanaz avatar Oct 09 '23 07:10 saschanaz

Done!

adeyinkaezra123 avatar Oct 09 '23 07:10 adeyinkaezra123

That went wrong, can you either rebase your commit on top of the current main branch or run npm i && npm run build && npm run baseline-accept instead?

saschanaz avatar Oct 09 '23 07:10 saschanaz

Done 💯

adeyinkaezra123 avatar Oct 09 '23 09:10 adeyinkaezra123

Any update concerning this @saschanaz ?

adeyinkaezra123 avatar Oct 13 '23 19:10 adeyinkaezra123

This still looks wrong, can you rebase and then run npm i && npm run build && npm run baseline-accept ? This PR should not add any new members.

saschanaz avatar Oct 17 '23 20:10 saschanaz

Hello @saschanaz This should also be closed

Bashamega avatar Apr 01 '25 07:04 Bashamega

Yeah, #1940 will handle this. Thanks!

@github-actions close

saschanaz avatar Apr 01 '25 07:04 saschanaz

Closing because @saschanaz is one of the code-owners of this repository.

github-actions[bot] avatar Apr 01 '25 07:04 github-actions[bot]