TypeScript-DOM-lib-generator Add augmentable `PermissionNameMap`

Jun 15 '23 08:06 Andarist

Thanks for the PR!

This section of the codebase is owned by @saschanaz - if they write a comment saying "LGTM" then it will be merged.

Jun 15 '23 08:06 github-actions[bot]

Interesting approach. Do you have any specific permission in mind you want to enable through this, BTW?

Jun 20 '23 00:06 saschanaz

Interesting approach.

I've seen other *Map types here and I thought that this was a somewhat established pattern here. But perhaps those other types had a different purpose after all 😅

Do you have any specific permission in mind you want to enable through this, BTW?

A friend of mine was trying to augment the related functions with 'clipboard-write' | 'clipboard-read'.

Jun 20 '23 06:06 Andarist

I've seen other *Map types here and I thought that this was a somewhat established pattern here. But perhaps those other types had a different purpose after all 😅

The key difference is that this one is not really a map but a list, while others are actual maps. Maybe rename?

A friend of mine was trying to augment the related functions with 'clipboard-write' | 'clipboard-read'.

In most cases you don't need those permissions, since user interaction e.g. mouse click and key push will automatically grant those permission for a short time (which is called transient user activation).

Jul 15 '23 02:07 saschanaz