SynapseML icon indicating copy to clipboard operation
SynapseML copied to clipboard

chore: Support Token Provider Mode

Open lhrotk opened this issue 2 years ago • 18 comments

What changes are proposed in this pull request?

Support token provider auth mode, auto refresh token while job is running.

How is this patch tested?

  • [ ] I have written tests (not required for typo or doc fix) and confirmed the proposed feature/bug-fix/change works.

Does this PR change any dependencies?

  • [ ] No. You can skip this section.
  • [x] Yes. Make sure the dependencies are resolved correctly, and list changes here.

"com.pauldijou" %% "jwt-core" % "3.0.0", "org.json" % "json" % "20180130",

Does this PR add a new feature? If so, have you added samples on website?

  • [x] No. You can skip this section.
  • [ ] Yes. Make sure you have added samples following below steps.

lhrotk avatar Jan 22 '24 16:01 lhrotk

/azp run

lhrotk avatar Jan 22 '24 16:01 lhrotk

Hey @lhrotk :wave:! Thank you so much for contributing to our repository :raised_hands:. Someone from SynapseML Team will be reviewing this pull request soon.

We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should make sure your first commit and PR title start with a semantic prefix. This helps us to create release messages and credit you for your hard work!

Examples of commit messages with semantic prefixes:

  • fix: Fix LightGBM crashes with empty partitions
  • feat: Make HTTP on Spark back-offs configurable
  • docs: Update Spark Serving usage
  • build: Add codecov support
  • perf: improve LightGBM memory usage
  • refactor: make python code generation rely on classes
  • style: Remove nulls from CNTKModel
  • test: Add test coverage for CNTKModel

To test your commit locally, please follow our guild on building from source. Check out the developer guide for additional guidance on testing your change.

github-actions[bot] avatar Jan 22 '24 16:01 github-actions[bot]

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Jan 22 '24 16:01 azure-pipelines[bot]

/azp run

lhrotk avatar Jan 23 '24 08:01 lhrotk

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Jan 23 '24 08:01 azure-pipelines[bot]

Codecov Report

Attention: Patch coverage is 38.06452% with 96 lines in your changes are missing coverage. Please review.

Project coverage is 84.16%. Comparing base (345bad9) to head (66fb110).

Files Patch % Lines
...crosoft/azure/synapse/ml/fabric/FabricClient.scala 35.71% 36 Missing :warning:
...t/azure/synapse/ml/fabric/OpenAITokenLibrary.scala 16.66% 25 Missing :warning:
...ft/azure/synapse/ml/fabric/FabricTokenParser.scala 0.00% 14 Missing :warning:
...re/synapse/ml/logging/common/PlatformDetails.scala 36.36% 7 Missing :warning:
...azure/synapse/ml/services/text/TextAnalytics.scala 50.00% 5 Missing :warning:
...ure/synapse/ml/services/CognitiveServiceBase.scala 66.66% 3 Missing :warning:
...soft/azure/synapse/ml/services/openai/OpenAI.scala 60.00% 2 Missing :warning:
...napse/ml/logging/fabric/CertifiedEventClient.scala 33.33% 2 Missing :warning:
.../microsoft/azure/synapse/ml/fabric/RESTUtils.scala 0.00% 1 Missing :warning:
...crosoft/azure/synapse/ml/fabric/TokenLibrary.scala 0.00% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2160      +/-   ##
==========================================
- Coverage   84.47%   84.16%   -0.31%     
==========================================
  Files         325      328       +3     
  Lines       16959    17067     +108     
  Branches     1524     1548      +24     
==========================================
+ Hits        14326    14365      +39     
- Misses       2633     2702      +69     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Jan 23 '24 09:01 codecov-commenter

/azp run

lhrotk avatar Jan 23 '24 11:01 lhrotk

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Jan 23 '24 11:01 azure-pipelines[bot]

/azp run

lhrotk avatar Jan 24 '24 09:01 lhrotk

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Jan 24 '24 09:01 azure-pipelines[bot]

/azp run

lhrotk avatar Jan 25 '24 10:01 lhrotk

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Jan 25 '24 10:01 azure-pipelines[bot]

/azp run

lhrotk avatar Jan 26 '24 07:01 lhrotk

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Jan 26 '24 07:01 azure-pipelines[bot]

/azp run

lhrotk avatar Feb 07 '24 08:02 lhrotk

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Feb 07 '24 08:02 azure-pipelines[bot]

/azp run

lhrotk avatar Feb 07 '24 11:02 lhrotk

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Feb 07 '24 11:02 azure-pipelines[bot]

/azp run

lhrotk avatar Feb 21 '24 08:02 lhrotk

/azp run

lhrotk avatar Feb 21 '24 08:02 lhrotk

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Feb 21 '24 08:02 azure-pipelines[bot]

/azp run

lhrotk avatar Feb 21 '24 08:02 lhrotk

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Feb 21 '24 08:02 azure-pipelines[bot]

/azp run

lhrotk avatar Feb 21 '24 12:02 lhrotk

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Feb 21 '24 12:02 azure-pipelines[bot]

/azp run

lhrotk avatar Feb 22 '24 05:02 lhrotk

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Feb 22 '24 05:02 azure-pipelines[bot]

/azp run

lhrotk avatar Feb 23 '24 14:02 lhrotk

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Feb 23 '24 14:02 azure-pipelines[bot]

/azp run

lhrotk avatar Feb 26 '24 08:02 lhrotk