SynapseML icon indicating copy to clipboard operation
SynapseML copied to clipboard

feat: Add LumpFeatures transfomer

Open dylanw-oss opened this issue 2 years ago • 2 comments

Related Issues/PRs

#1891

What changes are proposed in this pull request?

A transformer can be used to handle data with high cardinality skewed categorical before doing other featurization processing.

How is this patch tested?

unit test

Does this PR add a new feature? If so, have you added samples on website?

will add document in next commit (I'd like to ensure it makes sense before doing the next step)

  1. Find the corresponding markdown file for your new feature in website/docs/documentation folder. Make sure you choose the correct class estimators/transformers and namespace.
  2. Follow the pattern in markdown file and add another section for your new API, including pyspark, scala (and .NET potentially) samples.
  3. Make sure the DocTable points to correct API link.
  4. Navigate to website folder, and run yarn run start to make sure the website renders correctly.
  5. Don't forget to add <!--pytest-codeblocks:cont--> before each python code blocks to enable auto-tests for python samples.
  6. Make sure the WebsiteSamplesTests job pass in the pipeline.

dylanw-oss avatar Apr 26 '23 02:04 dylanw-oss

Hey @dylanw-oss :wave:! Thank you so much for contributing to our repository :raised_hands:. Someone from SynapseML Team will be reviewing this pull request soon.

We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should make sure your first commit and PR title start with a semantic prefix. This helps us to create release messages and credit you for your hard work!

Examples of commit messages with semantic prefixes:

  • fix: Fix LightGBM crashes with empty partitions
  • feat: Make HTTP on Spark back-offs configurable
  • docs: Update Spark Serving usage
  • build: Add codecov support
  • perf: improve LightGBM memory usage
  • refactor: make python code generation rely on classes
  • style: Remove nulls from CNTKModel
  • test: Add test coverage for CNTKModel

To test your commit locally, please follow our guild on building from source. Check out the developer guide for additional guidance on testing your change.

github-actions[bot] avatar Apr 26 '23 02:04 github-actions[bot]

if there is no objective for this feature, I'll add document. @sarahshy @memoryz

dylanw-oss avatar Apr 28 '23 21:04 dylanw-oss