SqlScriptDOM icon indicating copy to clipboard operation
SqlScriptDOM copied to clipboard

async version of `Microsoft.SqlServer.TransactSql.ScriptDom.TSqlFragmentVisitor`

Open lsoft opened this issue 4 years ago • 1 comments

I extensively use Microsoft.SqlServer.TransactSql.ScriptDom.TSqlFragmentVisitor to validate my queries against my DB schema, and in literally every of its method I need to execute some SQL queries (e.g. CreateCommand + ExecuteReader)

To make my code more modern, I want to use async methods (e.g. CreateCommand + ExecuteReaderAsync), so I need to have the following methods because these methods are above on my stack:

public abstract class TSqlFragmentVisitor
{
   public virtual Task ExplicitVisitAsync(FederationScheme node);
}

and

public abstract class TSqlFragment
{
        public virtual Task AcceptAsync(TSqlFragmentVisitor visitor);
        public virtual Task AcceptChildrenAsync(TSqlFragmentVisitor visitor);

}

Please consider to add these methods.

Thank you!

lsoft avatar Sep 30 '21 16:09 lsoft

Also submitted to the VS dev community - https://developercommunity.visualstudio.com/t/async-version-of-MicrosoftSqlServerTra/1477828

dzsquared avatar Jun 28 '22 18:06 dzsquared