Recognizers-Text icon indicating copy to clipboard operation
Recognizers-Text copied to clipboard
verified publisher icon microsoft

[TimexLib] Fixed first week of the year timex resolution

Open nikhilkandur opened this issue 4 years ago • 3 comments

  • Timex like '2021-W01', '2020-W01' are now resolved correctly
  • Added a test case, test_datatypes_resolver_dateRange_first_week

nikhilkandur avatar Aug 03 '21 20:08 nikhilkandur

PR for issue #2685

nikhilkandur avatar Aug 03 '21 20:08 nikhilkandur

yeah, this PR only changed the typo error of start to end and nothing with the logic of first week calculation. Looking into @nawans comment, I said it here, 2685#issuecomment-892932735 regarding calculation inconsistency. And also thoughts on this comment, 2685#issuecomment-892951931

nikhilkandur avatar Nov 05 '21 16:11 nikhilkandur

And also, I think, we need to revisit quarters calculation as well, as the python one may not be following ISO standards.

nikhilkandur avatar Nov 05 '21 17:11 nikhilkandur