PowerShellForGitHub icon indicating copy to clipboard operation
PowerShellForGitHub copied to clipboard

Repair log file encoding on module load if required

Open giuseppecampanelli opened this issue 5 years ago • 13 comments

Description

Repair log file encoding from UTF16 to UTF8 when the module is loaded if required

Issues Fixed

Fixes #237

Checklist

  • [ ] You actually ran the code that you just wrote, especially if you did just "one last quick change".
  • [x] Comment-based help added/updated, including examples.
  • [x] Static analysis is reporting back clean.
  • [x] New/changed code adheres to our coding guidelines.
  • [ ] New/changed code continues to support the pipeline.
  • [ ] Changes to the manifest file follow the manifest guidance.
  • [ ] Unit tests were added/updated and are all passing. See testing guidelines. This includes making sure that all pipeline input variations have been covered.
  • [ ] Relevant usage examples have been added/updated in USAGE.md.
  • [ ] If desired, ensure your name is added to our Contributors list

giuseppecampanelli avatar Jun 25 '20 20:06 giuseppecampanelli

@HowardWolosky thank you for the comments so far. I have yet to test, I just wanted to create a PR to show some progress.

I do have a question in regards to how you prefer PRs. Should I only create the PR after everything is tested and functioning or is it alright to create a draft PR just to show progress? I don't want to waste your time always if it's not complete but want to show progress, and also in case there could be valuable input to give along the way?

giuseppecampanelli avatar Jun 26 '20 01:06 giuseppecampanelli

Thanks for asking! Draft PR's that are just showing progress are totally ok, however it's important to be clear about the state that it's in when you submit it.

So, if you're submitting it and haven't tested/verified it yet, please just explicitly say so. If you're not looking for a thorough code review and just want general confirmation that you're on the right track, say that. Just be clear with why you're submitting the PR, and that will tell me how thoroughly I should be looking at it.

Thanks for the help!

HowardWolosky avatar Jun 26 '20 02:06 HowardWolosky

@HowardWolosky Thank you for the information!

giuseppecampanelli avatar Jun 26 '20 02:06 giuseppecampanelli

Pending testing

giuseppecampanelli avatar Jun 27 '20 13:06 giuseppecampanelli

I will let you know once I've completed testing

giuseppecampanelli avatar Jun 29 '20 15:06 giuseppecampanelli

I will let you know once I've completed testing

Sounds good. The code is looking pretty solid now, and I look forward to seeing your testing strategy.

HowardWolosky avatar Jun 29 '20 16:06 HowardWolosky

Apologies for the delay, I was wrapping up my last 2 weeks of internship. I'll get on this hopefully shortly.

giuseppecampanelli avatar Jul 06 '20 18:07 giuseppecampanelli

Hey @themilanfan -- Just wanted to check-in with you to see how things are going here.

Hope your internship went well!

Do you think you'll be coming back to this PR anytime soon?

HowardWolosky avatar Aug 10 '20 03:08 HowardWolosky

Hey @themilanfan -- wanted to check-in to see if you think you'll be coming back to this PR?

Thanks!

HowardWolosky avatar Sep 09 '20 14:09 HowardWolosky

/azp run PowerShellForGitHub-CI

HowardWolosky avatar Oct 16 '20 22:10 HowardWolosky

Pull request contains merge conflicts.

azure-pipelines[bot] avatar Oct 16 '20 22:10 azure-pipelines[bot]

Hi @themilanfan -- I wanted to check-in with you to see if you're planning on returning to his PR, or if someone else should take it over. Thanks!

HowardWolosky avatar Oct 23 '20 17:10 HowardWolosky

Hi @HowardWolosky apologies for not responding. I've been very busy with work and school as I'm finishing up my last semester. I could probably get to it after my semester is done in December, but if you need this completed sooner and someone else would like to take it over that's fine with me.

giuseppecampanelli avatar Oct 30 '20 22:10 giuseppecampanelli

This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 7 days. It will be closed if no further activity occurs within 14 days of this comment.

This pull request has been automatically closed due to a lack of activity from the author. We understand. Life happens and other things likely came up. We would still love to see your contribution get merged in. Now that it has been closed, a different community member may wish to pick up where you left off. If so, they should speak up by commenting below. If you're still interested in completing this yourself, just respond back and let us know.